Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 89135 - app-admin/gkrellm builds and runs with glib-2
Summary: app-admin/gkrellm builds and runs with glib-2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Martin Holzer (RETIRED)
URL:
Whiteboard:
Keywords:
: 84088 102671 119488 122541 (view as bug list)
Depends on: 129257
Blocks:
  Show dependency tree
 
Reported: 2005-04-14 15:39 UTC by Marien Zwart (RETIRED)
Modified: 2006-05-02 05:42 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
the "second patch": make gkrellm always use glib 2 (gkrellm.patch,550 bytes, patch)
2005-04-14 15:43 UTC, Marien Zwart (RETIRED)
Details | Diff
the "first patch": make USE=X gkrellm use glib 2 (gkrellm.patch,430 bytes, patch)
2005-04-14 15:45 UTC, Marien Zwart (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Marien Zwart (RETIRED) gentoo-dev 2005-04-14 15:39:15 UTC
The latest gkrellm ebuild has a hard dependency on "=glib-1*". This is probably there because of bug 65969, which mentions a USE=-X build (gkrellmd only) needs glib 1. However:

- USE=X builds and runs just fine with glib 2.
- USE=-X builds and seems to run (not heavily tested) just fine with glib 2 if the line "emake glib12=1 || die" is changed to just "emake || die"

I'm not sure why the glib12=1 was there to begin with, so I'm attaching two simple patches. 

The first one changes the DEPEND so it depends on any glib (so it'll build with glib 2) if USE=X and with glib 1 if USE=-X. I've been running my desktop without glib 1 for a while now, so I'm pretty sure this works just fine. AFAIK gkrellm2 wasn't using glib1 anyway (since it depends on gtk+-2).

The second one changes the depend to always be on "just glib" and makes gkrellmd build with that. This second patch "should" work afaik, but I haven't used the glib2 gkrellmd much, and there may be reasons I don't know about why that glib12=1 was put there.

Reproducible: Always
Steps to Reproduce:
1. have a system without glib-1 (which is doable now that ~x86 pam doesn't need glib 1 anymore)
2. emerge gkrellm (the ~x86 version, gkrellm-2.2.5)
Actual Results:  
glib-1 was pulled in.

Expected Results:  
used glib-2

Gentoo Base System version 1.6.10
Portage 1.585-cvs (default-linux/x86/2005.0, gcc-3.4.3-20050110,
glibc-2.3.4.20050125-r1, 2.6.11-gentoo-r6-m1 i686)
=================================================================
System uname: 2.6.11-gentoo-r6-m1 i686 AMD Athlon(tm) XP 2600+
Python:              dev-lang/python-2.4-r3 [2.4 (#1, Apr 13 2005, 00:34:01)]
distcc: No such file or directory [disabled]
dev-lang/python:     2.4-r3
sys-devel/autoconf:  2.59-r6, 2.13
sys-devel/automake:  1.7.9-r1, 1.8.5-r3, 1.5, 1.4_p6, 1.6.3, 1.9.5
sys-devel/binutils:  2.15.92.0.2-r8
sys-devel/libtool:   1.5.14
virtual/os-headers:  2.6.8.1-r4
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-O2 -march=athlon-xp -pipe -fomit-frame-pointer -fweb -frename-registers"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3.4/env
/usr/kde/3.4/share/config /usr/kde/3.4/shutdown /usr/kde/3/share/config
/usr/lib/X11/xkb /usr/lib/mozilla/defaults/pref /usr/share/config
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/texmf/web2c /etc/env.d"
CXXFLAGS="-O2 -march=athlon-xp -pipe -fomit-frame-pointer -fweb -frename-registers"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs autoconfig candy ccache distlocks noauto sandbox sfperms
userpriv usersandbox verify-rdepend"
GENTOO_MIRRORS="http://ftp.easynet.nl/mirror/gentoo/"
LANG="en_US.UTF-8"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/private /usr/local/portage/pub"
SYNC="rsync://rsync.nl.gentoo.org/gentoo-portage"
USE="x86 3dnow 3dnowex 3dnowext X a52 alsa ansi bonobo bzip2 ccache cdr crypt
eds emacs evo evo2 faad fbcon flac gif glut gnome gstreamer gtk2 hal javascript
jit jpeg kdeenablefinal libcaca mad maildir md5sum mikmod mmx mmx2 mmxext mng
mono mozdevelop mozsvg mpeg ncurses nethack network nls nntp no-helpbrowser
no-old-linux nonfsv4 nowebdav nptl nptlonly ogg oggvorbis opengl pam png python
qemu-fast quicktime readline rtc sdl softmmu spell splash sse ssl
startup-notification svg symlink tetex theora truetype truetype-fonts unicode
userlocales xml2 xv zlib"
Unset:  ASFLAGS, CBUILD, CTARGET, LC_ALL, LDFLAGS, LINGUAS
Comment 1 Marien Zwart (RETIRED) gentoo-dev 2005-04-14 15:43:30 UTC
Created attachment 56303 [details, diff]
the "second patch": make gkrellm always use glib 2

patch to gkrellm-2.2.5.ebuild, makes both the X and -X build use the "new"
glib.
Comment 2 Marien Zwart (RETIRED) gentoo-dev 2005-04-14 15:45:10 UTC
Created attachment 56304 [details, diff]
the "first patch": make USE=X gkrellm use glib 2
Comment 3 Daniel Webert 2005-05-19 06:35:28 UTC
*** Bug 84088 has been marked as a duplicate of this bug. ***
Comment 4 gent_bz 2005-07-31 23:46:12 UTC
To solidify the basis for making a change to the dependency of gkrellm-2 on
glib-2, www.gkrellm.net states that gkrellm *requires* glib-2, and that gkrellmd
will work with either glib-1.2 or glib-2.

USE=X should DEPEND on >=glib-2 and USE=-X should DEPEND on >=glib-1.2
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2005-08-16 02:52:00 UTC
*** Bug 102671 has been marked as a duplicate of this bug. ***
Comment 6 Andrea Ratto 2005-12-17 11:56:34 UTC
The daemon seems to work with any glib version, so I think DEPEND should be:
DEPEND="!X? ( dev-libs/glib )
 	ssl? ( dev-libs/openssl )
 	X? ( >=x11-libs/gtk+-2.0.5
 		>=x11-libs/pango-1.4.0 )"

the line:
emake glib12=1 || die
seems to work even on a glib-2 only system, so I think it could be left as is, with the only effect to prefer glib-1 over glib-2 IF glib-1 is installed (not sure about this).

This bug has reached the stable branch, and caused my "x86" system to install glib-1. Really few packages use that lib nowaday. (mplayer and nmap are switching to gtk2 too) so please fix thise one.
Comment 7 gent_bz 2005-12-29 17:05:47 UTC
This is an easy fix that is long overdue - could someone please check it in?
Comment 8 Jakub Moc (RETIRED) gentoo-dev 2006-02-12 03:57:36 UTC
*** Bug 119488 has been marked as a duplicate of this bug. ***
Comment 9 Jakub Moc (RETIRED) gentoo-dev 2006-02-12 03:57:52 UTC
*** Bug 122541 has been marked as a duplicate of this bug. ***
Comment 10 Martin Holzer (RETIRED) gentoo-dev 2006-05-02 05:42:07 UTC
fixed with #129257