Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 891195 - net-misc/rygel-0.42.0: X11 is required only when gtk USE flag is set
Summary: net-misc/rygel-0.42.0: X11 is required only when gtk USE flag is set
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-17 13:42 UTC by Jocelyn Mayer
Modified: 2023-01-31 11:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
output from emerge --info =net-misc/rygel-0.42.0 (emerge-infos-rygel-0.42.0,25.64 KB, text/plain)
2023-01-17 13:43 UTC, Jocelyn Mayer
Details
Patch to remove X11 dependency from rygel configure and build (rygel-0.42.0-noX.patch,1.01 KB, patch)
2023-01-17 13:44 UTC, Jocelyn Mayer
Details | Diff
net-misc/rygel-0.42.0.ebuild patch to remove unneeded X11 dependency when gtk+ is not used (net-misc_rygel_rygel-0.42.0.ebuild.patch,617 bytes, patch)
2023-01-17 13:45 UTC, Jocelyn Mayer
Details | Diff
Updated patch to remove X11 dependency from rygel configure and build (net-misc_rygel_rygel-0.42.0.ebuild.patch,617 bytes, patch)
2023-01-17 19:36 UTC, Jocelyn Mayer
Details | Diff
Updated patch to remove X11 dependency from rygel configure and build (rygel-0.42.0-noX.patch,1.01 KB, patch)
2023-01-17 19:39 UTC, Jocelyn Mayer
Details | Diff
Update net-misc/rygel-0.42.0.ebuild patch to remove unneeded X11 dependency when gtk+ is not used (net-misc_rygel_rygel-0.42.0.ebuild.patch,617 bytes, patch)
2023-01-17 19:40 UTC, Jocelyn Mayer
Details | Diff
Updated patch to remove X11 dependency from rygel configure and build (rygel-0.42.0-noX.patch,1.27 KB, patch)
2023-01-31 11:58 UTC, Jocelyn Mayer
Details | Diff
Update net-misc/rygel-0.42.0.ebuild patch to remove unneeded X11 dependency when gtk+ is not used (net-misc_rygel_rygel-0.42.0.ebuild.patch,549 bytes, patch)
2023-01-31 11:59 UTC, Jocelyn Mayer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Mayer 2023-01-17 13:42:22 UTC
rygel package depends on X11 only when using GTK+.
On a server with X server, it can be used without any X11 support, if USE="-gtk" is set.

Reproducible: Always

Steps to Reproduce:
1. Choose a machine without X11 server installed
2. Try to build rygel

Actual Results:  
The build fails because of an unused X11 dependency

Expected Results:  
rygel to install without x11 support

there currently is an hardcoded X11 dependency in the rygel build system.
Following is a patch proposal to get rid of this unneeded dependecy when GTK+ is not used.
The proposed patched is far from being perfect: it would better be a configure / compile time checking rather than the way it is in this proposal. But it seems to do the trick....
Comment 1 Jocelyn Mayer 2023-01-17 13:43:19 UTC
Created attachment 848729 [details]
output from emerge --info =net-misc/rygel-0.42.0
Comment 2 Jocelyn Mayer 2023-01-17 13:44:10 UTC
Created attachment 848731 [details, diff]
Patch to remove X11 dependency from rygel configure and build
Comment 3 Jocelyn Mayer 2023-01-17 13:45:10 UTC
Created attachment 848733 [details, diff]
net-misc/rygel-0.42.0.ebuild patch to remove unneeded X11 dependency when gtk+ is not used
Comment 4 Jocelyn Mayer 2023-01-17 19:36:02 UTC
Created attachment 848751 [details, diff]
Updated patch to remove X11 dependency from rygel configure and build
Comment 5 Jocelyn Mayer 2023-01-17 19:39:28 UTC
Created attachment 848753 [details, diff]
Updated patch to remove X11 dependency from rygel configure and build

this patch can be applied unconditionally, as it uses the gtk option to disable the x11 dependency requirement and X.init_threads call
Comment 6 Jocelyn Mayer 2023-01-17 19:40:46 UTC
Created attachment 848755 [details, diff]
Update net-misc/rygel-0.42.0.ebuild patch to remove unneeded X11 dependency when gtk+ is not used

This patch to the rygel 0.42.0 version ebuild is to be used with the updated patch to remove X11 dependency when gtk is not in use
Comment 7 Jocelyn Mayer 2023-01-18 10:31:10 UTC
just opened a request on gitlab rygel repository:

https://gitlab.gnome.org/GNOME/rygel/-/issues/221
Comment 8 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-19 01:28:30 UTC
We don't like to do conditional patching (as in, conditionally applying a patch): https://devmanual.gentoo.org/ebuild-writing/misc-files/patches/index.html#conditional-patching.
Comment 9 Jocelyn Mayer 2023-01-29 18:28:23 UTC
i fully understand that, as the upstream maintainer refused the patch telling this was not a case to be supported and I should better install a X server on this headless online server (!), it seems to me that an even better patch would be to add a X USE flags so the patch could be always applied...
Comment 10 Jocelyn Mayer 2023-01-31 11:58:30 UTC
Created attachment 849554 [details, diff]
Updated patch to remove X11 dependency from rygel configure and build

This patch still does not use a X configuration flags but can be applied in any cases
Comment 11 Jocelyn Mayer 2023-01-31 11:59:45 UTC
Created attachment 849555 [details, diff]
Update net-misc/rygel-0.42.0.ebuild patch to remove unneeded X11 dependency when gtk+ is not used

this patch always does not requires conditional patching of the build system