Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 890308 - x11-misc/xscreensaver-6.05-r1 ebuild inadvertently requiring gtk+-3
Summary: x11-misc/xscreensaver-6.05-r1 ebuild inadvertently requiring gtk+-3
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Pascal Jäger
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2023-01-09 21:39 UTC by Tom Dexter
Modified: 2023-02-27 20:30 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log without gtk+-3 (build.log,19.37 KB, text/x-log)
2023-01-10 09:52 UTC, Tom Dexter
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Dexter 2023-01-09 21:39:29 UTC
The current ebuild for x11-misc/xscreensaver-6.05-r1 has this line:

gtk? ( >=x11-libs/gtk+-2.22.0:3 )

I believe the :3 in there is intended to be :2 as this pulls in gtk+-3 even when gtk+-2 is installed.

Thanks!
Comment 1 Tom Dexter 2023-01-10 09:52:44 UTC
Created attachment 848056 [details]
Build log without gtk+-3
Comment 2 Tom Dexter 2023-01-10 09:56:32 UTC
This one just got a bit more complicated. When I made that correction to the ebuild it corrected the dependency part of this, but the compile failed at the end of the configure phase without gtk+3.

I should note that this specific case is on an x86 system. I've attached the build.log. It doesn't appear to be too clear as to exactly what failed.
Comment 3 Tom Dexter 2023-01-10 10:04:22 UTC
I should also note that I get the same configure failure if I try to compile without the gtk USE enabled at all.
Comment 4 Tom Dexter 2023-01-10 19:40:56 UTC
So this one gets much more complex than I thought, and there may in fact be no real issue here:

Even according to the upstream changelog, GTK 3 actually IS required for 6.05 assuming you use GTK at all.

As it turned out, the failure in the config stage that I was getting, which happened even with the gtk USE flag disabled, was being caused by something totally unrelated: I had an old /etc/pam.d directory even though PAM wasn't installed, and the configure script uses that directory to assume that PAM is available, but not being used for xscreensaver which caused the config failure.

So again, I don't think there's any issue here, as the only options are to use GTK 3 or no GTK at all...the latter being what I'm now using.
Comment 5 Pascal Jäger 2023-02-27 20:30:35 UTC
Yes, this really gets incredibly complicated. 

So, with 6.05 upstream switched from gtk2 to gtk3 finally. 
What upstream did not do is update the version check for gtk in their configure scripts.
So, the version that we have to have at least is 2.22.0, but it must be gtk3. 

In reality this is nonsense, there is no gtk3 with version 2.22.0. But I did not want to pick an arbitrary version number, as this would confuse even more. So I kept the version that upstream is checking for and used to slot number to make sure it is gtk3.

 (In reply to Tom Dexter from comment #3)
> I should also note that I get the same configure failure if I try to compile
> without the gtk USE enabled at all.

This should not happen. Even if this is caused by something unrelated it should not report a wrong error message then.
From version 6.06 on I wanted to drop the option to build without gtk entirely since upstream dropped it as well. So I think there is not much sense in putting in the energy to fix that.