Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 88894 - Proposed fixes for ppc64 handbook
Summary: Proposed fixes for ppc64 handbook
Status: RESOLVED FIXED
Alias: None
Product: [OLD] Docs-user
Classification: Unclassified
Component: Handbook (show other bugs)
Hardware: PPC64 Linux
: High normal (vote)
Assignee: Sven Vermeulen (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-12 13:42 UTC by Brent Baude (RETIRED)
Modified: 2005-04-21 06:29 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for documentation (docs.patch,7.42 KB, patch)
2005-04-12 13:43 UTC, Brent Baude (RETIRED)
Details | Diff
New patch - ignore older one (docs.patch,7.42 KB, patch)
2005-04-12 13:56 UTC, Brent Baude (RETIRED)
Details | Diff
Adjusted patch (ppc64.patch,6.63 KB, patch)
2005-04-20 08:48 UTC, Joe Jezak (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Baude (RETIRED) gentoo-dev 2005-04-12 13:42:46 UTC
The following patch is a set of proposed patches to improve the handbook for ppc64 installations.

One concern I had before making the fixes is that I had to add ppc64 specific stuff to the shared files. Specifically this includes:

- hb-install-config.xml
- hb-install-tools.xml

I had talked with Swift about this (i.e whether we should make ppc64 versions of these files) but he preferred to add it to the 'shared' files. 

The other fixes are patching ppc64 specific files.


Reproducible: Always
Steps to Reproduce:
NA
Actual Results:  
NA
Comment 1 Brent Baude (RETIRED) gentoo-dev 2005-04-12 13:43:57 UTC
Created attachment 56122 [details, diff]
patch for documentation
Comment 2 Brent Baude (RETIRED) gentoo-dev 2005-04-12 13:44:29 UTC
adding dostrow and tgall
Comment 3 Brent Baude (RETIRED) gentoo-dev 2005-04-12 13:56:03 UTC
Created attachment 56124 [details, diff]
New patch - ignore older one

please use this patch
Comment 4 Sven Vermeulen (RETIRED) gentoo-dev 2005-04-16 13:26:46 UTC
JoseJX: SeJo told me you're going for the nutcase^Wdocumentation development :) Could you do a review on this patch (see if it's fundamentally flawed - although I don't think this'll happen) and recreate it with the Coding Style?

If you're not aware of the Coding Style, see http://www.gentoo.org/doc/en/xml-guide.xml. Also, if the patches are too important to wait until you get a grip at the coding style, just say if they're correct or not, I'll update the patches to be conform the coding style, commit but also attach those so you can see the difference.
Comment 5 Joe Jezak (RETIRED) gentoo-dev 2005-04-20 08:48:08 UTC
Created attachment 56763 [details, diff]
Adjusted patch

I've attached an adjusted patch.  I didn't include the checklist before
rebooting as it seemed redundant and incomplete.  However, I did include some
of these steps elsewhere. If this is something we'd like to have, I'll expand
on it and add it in.
Comment 6 Brent Baude (RETIRED) gentoo-dev 2005-04-20 19:31:33 UTC
JoseX,

Your call.  I felt like a quick checklist wouldn't have hurt and yes, it is redundant if you dont read the docs closely.  Thanks for considering it elsewhere?

Based on the ppc questions I get about gentoo, a checklist might be appropriate towards the end.

At this time however, I would consider it closed when your patch is applied.

Comment 7 Sven Vermeulen (RETIRED) gentoo-dev 2005-04-21 06:29:09 UTC
Thanks. I've applied the patch with the following (cosmetic) changes:

- Between </p> and </body> there should be a blank line (Coding Style)
- Between <body> and <note> there should be a blank line (Coding Style)
- Lines should be wrapped at 80 characters
- Typo: s/Crating/Creating/

I'll close this one unless there's something I forgot.