Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 88869 - media-libs/xine-lib ebuild cleanup
Summary: media-libs/xine-lib ebuild cleanup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-12 09:19 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2005-04-13 09:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
xine-lib-ebuild.patch (xine-lib-ebuild.patch,5.58 KB, patch)
2005-04-12 09:19 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
xine-lib-configure-checks.patch (xine-lib-configure-checks.patch,11.55 KB, patch)
2005-04-12 09:19 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
xine-lib-ebuild.patch (xine-lib-ebuild.patch,6.70 KB, patch)
2005-04-12 10:05 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
xine-lib-configure-xvmc-header.patch (xine-lib-configure-xvmc-header.patch,901 bytes, patch)
2005-04-12 10:06 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
xine-lib-ebuild.patch (xine-lib-ebuild.patch,6.72 KB, patch)
2005-04-12 10:22 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-12 09:19:03 UTC
This patch applied over the current ebuild cleans it up:

- it changes the avi useflag in win32codecs useflag which is now a global useflag and is masked in the arches which doesn't use it.
- it adds a block on the old version of xine-lib, instead of failing if it's installed.
- it adds pkgconfig as a DEPEND, as it's used for a lot of things (and many will come I think), instead of having it as RDEPEND when gnome or directfb are used.
- it cleansup amd64? () depends which seems bogus.
- it adds conditional dependency on flac (see later).
- it adds build-time dependency on linux-headers if v4l is requested (see later).
- cleanups the patches applied, some where applied to configure when it was going to be recreated by scratch.
- dies when autotools fails their execution.
- it adds --disable-dependency-tracking to econf
- and finally, it adds a patch (attached also) which adds a few --disable-XXXX params to ./configure, allowing to remove the dirt ac cache tricks :)

I've submitted the configure.ac patch upstream and I hope it will applied for the next version.
I'll continue working on this to have proper fixes for other gentoo's workarounds applied upstream for next version (and to cleanup the ebuild, too).

Oh.. now oss CAN be disabled, so no more auto audio driver which fallbacks on oss if other fails, if not requested :)

HTH, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-12 09:19:31 UTC
Created attachment 56090 [details, diff]
xine-lib-ebuild.patch
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-12 09:19:54 UTC
Created attachment 56091 [details, diff]
xine-lib-configure-checks.patch
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-12 10:05:47 UTC
Created attachment 56099 [details, diff]
xine-lib-ebuild.patch

This updated ebuild adds another patch, which narrows down the ebuild a bit.
It fixes in a more proper way bug #82571, without need to pass --x-includes
parameter, and without need to check for where does that file is.
It changes the configure.ac so it's needed the other patch I'll attach. I'll
submit this upstream, too.

It also removes the warnings about previous xine-lib versions (it now blocks
them), and the one about the old plugins (they are no more in portage, anyway),
and change the warning about .xine (upgrade works fine).
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-12 10:06:02 UTC
Created attachment 56100 [details, diff]
xine-lib-configure-xvmc-header.patch
Comment 5 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-12 10:22:58 UTC
Created attachment 56102 [details, diff]
xine-lib-ebuild.patch

Someone is going to hate me :)
Just a bit change $(use_enable x11) is no more present on configure, so remove
this.
Comment 6 Jan Brinkmann (RETIRED) gentoo-dev 2005-04-13 09:48:54 UTC
fixed in cvs, thanks for the effort. would be nice if upstream merges the configure patches into their tree.