Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 888237 - dev-python/braintree: still depends on dev-python/nose
Summary: dev-python/braintree: still depends on dev-python/nose
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Cédric Krier
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 822414
  Show dependency tree
 
Reported: 2022-12-25 08:25 UTC by Michał Górny
Modified: 2023-01-15 08:55 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-12-25 08:25:43 UTC 
See tracker.
Comment 1 Cédric Krier gentoo-dev 2022-12-25 09:52:32 UTC 
Upstream has already dropped nose requirements for the next release: https://github.com/braintree/braintree_python/pull/146
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-01-11 20:13:15 UTC 
4.18.0 is out but it doesn't seem that the tests work without Internet access.
Comment 3 Cédric Krier gentoo-dev 2023-01-11 21:52:26 UTC 
(In reply to Michał Górny from comment #2)
> 4.18.0 is out but it doesn't seem that the tests work without Internet
> access.

For me the unit part the tests do not require internet access and of course the integration part requires it.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-12 10:43:03 UTC 
Can you run just the unit tests then? (Or possibly conditionally run more if PROPERTIES contains test_network?)
Comment 5 Cédric Krier gentoo-dev 2023-01-12 11:28:28 UTC 
(In reply to Sam James from comment #4)
> Can you run just the unit tests then?

It is already the case: `nosetests -v tests/unit` and the test passes with FEATURES="network-sandbox".

> (Or possibly conditionally run more if PROPERTIES contains test_network?)

I do not understand what you mean. PROPERTIES is for the definition of the ebuild.
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-01-12 11:36:48 UTC 
Oh, yes, thanks!
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-01-12 11:37:45 UTC 
(In reply to Cédric Krier from comment #3)
> (In reply to Michał Górny from comment #2)
> > 4.18.0 is out but it doesn't seem that the tests work without Internet
> > access.
> 
> For me the unit part the tests do not require internet access and of course
> the integration part requires it.

Right, my bad.

Let's keep the bug open until the old version is removed.
Comment 8 Cédric Krier gentoo-dev 2023-01-12 12:32:32 UTC 
(In reply to Michał Górny from comment #7)
> (In reply to Cédric Krier from comment #3)
> > (In reply to Michał Górny from comment #2)
> > > 4.18.0 is out but it doesn't seem that the tests work without Internet
> > > access.
> > 
> > For me the unit part the tests do not require internet access and of course
> > the integration part requires it.
> 
> Right, my bad.
> 
> Let's keep the bug open until the old version is removed.

I'm currently updating to Python 3.11 to bump the package and include Python 3.11 and remove nose.
Comment 9 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2023-01-15 08:55:43 UTC 
commit 20d65fc41c9e3b180b8363d7838fa10b1e682779
Author:     Cédric Krier <cedk@gentoo.org>
AuthorDate: 2023-01-12 14:38:26 +0100
Commit:     Cédric Krier <cedk@gentoo.org>
CommitDate: 2023-01-12 14:42:11 +0100

    dev-python/braintree: add 4.18.0, drop 4.17.1


I'm guessing it hit Bugzilla downtime.