Bug 8882 – php-4.2.2-r1.ebuild is missing support for libpng

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description PJ 2002-10-08 00:52:41 UTC]

As far as I can tell every single ebuild before php-4.2.2-r1.ebuild has the 
following line:

use png && myconf="${myconf} --with-png-dir=/usr"

However, php-4.2.2-r1.ebuild is missing this line. It has the dependency check, 
but it doesn't have the line that actually adds the configure option --with-
png. 

Not sure why it got taken out, but my theory was when rphillips was fixing bug 
#2708 (see "# rphillips - should fix #2708" in the ebuild file) he just 
accidentally deleted the line. That's my guess anyway, since he changed code 
RIGHT where the missing line should be.

-PJ
http://www.elitegamer.com

[Comment 1 SpanKY 2002-10-08 10:06:07 UTC]

looks like a simple mistake ... notice the duplicate tiff in the first and the 
correct handling in the 2nd ... 
  
/usr/portage/dev-php/php/php-4.2.2-r1.ebuild:  
        use tiff && myconf="${myconf} --with-tiff-dir=/usr"  
  
        # rphillips - should fix #2708  
        if [ "`use pdflib`" ] ; then  
                myconf="${myconf} --enable-pdflib=/usr"  
        else  
                use jpeg && myconf="${myconf} --with-jpeg-dir=/usr/lib"  
                use tiff && myconf="${myconf} --with-tiff-dir=/usr"  
        fi  
  
/usr/portage/dev-php/mod_php/mod_php-4.2.2-r1.ebuild  
         use png && myconf="${myconf} --with-png-dir=/usr" 
 
        # rphillips - should fix #2708 
        if [ "`use pdflib`" ] ; then 
                myconf="${myconf} --with-pdflib=/usr" 
        else 
                use jpeg && myconf="${myconf} --with-jpeg-dir=/usr/lib" 
                use tiff && myconf="${myconf} --with-tiff-dir=/usr" 
        fi 
 

[Comment 2 PJ 2002-10-08 22:22:16 UTC]

I just wanted to add that this is NOT a problem in mod_php.

[Comment 3 SpanKY 2002-10-08 23:23:30 UTC]

i know ... i was showing that mod_php did it correctly ...

[Comment 4 Ryan Phillips (RETIRED) 2002-10-18 01:21:53 UTC]

committed