Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 887243 - sys-process/btop-1.12.13 cc1plus: error: '-fcf-protection' is not compatible with this target (i486/i586)
Summary: sys-process/btop-1.12.13 cc1plus: error: '-fcf-protection' is not compatible ...
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Adrian Schollmeyer
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-19 16:48 UTC by immolo
Modified: 2023-02-18 18:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
btop build.log (BTOP.txt,6.30 KB, text/plain)
2022-12-19 16:48 UTC, immolo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description immolo 2022-12-19 16:48:38 UTC
Created attachment 843863 [details]
btop build.log

For some reason the ebuild is setting -fcf-protection while building btop on i486 yet if you manually install the program from source it won't add this flag and will work correctly.

I have patched the line out of the Makefile and then it works as intended but I'm sure a better solution can be found.

Error:
Compiling src/btop_tools.cpp
i686-gentoo-linux-musl-g++ -Os -march=i486 -pipe -fomit-frame-pointer -fcf-protection=none -std=c++20 -pthread -D_FORTIFY_SOURCE=2 -D_GLIBCXX_ASSERTIONS -fexceptions -fstack-clash-protection -fcf-protection -fstack-protector   -Wall -Wextra -pedantic -Iinclude -Isrc -MMD -c -o obj/btop_tools.o src/btop_tools.cpp
cc1plus: error: '-fcf-protection' is not compatible with this target

Steps to Reproduce:

1. Setup i486/586 machine
2. emerge -va sys-process/btop
Comment 1 immolo 2022-12-19 16:52:10 UTC
# emerge --info
Portage 3.0.38.1 (python 3.10.8-final-0, default/linux/x86/17.0/musl, gcc-11.3.0, musl-1.2.3, 5.15.77-gentoo-dist i686)
=================================================================
System uname: Linux-5.15.77-gentoo-dist-i686-QEMU_Virtual_CPU_version_2.5+-with-libc
KiB Mem:     3094072 total,   1218160 free
KiB Swap:          0 total,         0 free
Timestamp of repository gentoo: Mon, 19 Dec 2022 16:00:01 +0000
Head commit of repository gentoo: dabf43ed34073d05c3a033069c51ccea7ea0ff52
sh bash 5.1_p16-r2
ld GNU ld (Gentoo 2.38 p4) 2.38
app-misc/pax-utils:        1.3.5::gentoo
app-shells/bash:           5.1_p16-r2::gentoo
dev-lang/perl:             5.34.1-r4::gentoo
dev-lang/python:           3.10.8_p3::gentoo, 3.11.0_p2::gentoo
dev-util/meson:            0.63.2-r1::gentoo
sys-apps/baselayout:       2.9::gentoo
sys-apps/openrc:           0.45.2-r1::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-devel/autoconf:        2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.38-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/gcc:             11.3.0::gentoo
sys-devel/gcc-config:      2.8::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.15-r3::gentoo (virtual/os-headers)
sys-libs/musl:             1.2.3::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts: 
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-max-age: 24

ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="*"
CBUILD="i686-gentoo-linux-musl"
CFLAGS="-Os -march=i486 -pipe -fomit-frame-pointer -fcf-protection=none"
CHOST="i686-gentoo-linux-musl"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-Os -march=i486 -pipe -fomit-frame-pointer -fcf-protection=none"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-Os -march=i486 -pipe -fomit-frame-pointer -fcf-protection=none"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-Os -march=i486 -pipe -fomit-frame-pointer -fcf-protection=none"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
INSTALL_MASK="charset.alias /usr/share/locale/locale.alias"
LANG="C.UTF8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="acl bzip2 cli crypt dri fortran iconv ipv6 libglvnd libtirpc ncurses nls nptl openmp pam pcre pic readline seccomp split-usr ssl test-rust unicode x86 xattr zlib" ABI_X86="32" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="musl" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, MAKEOPTS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 2 Adrian Schollmeyer 2022-12-22 12:00:44 UTC
I haven't tried reproducing it yet since I'd have to set up a 486 VM for this. However, I have grepped through the Makefile:

[nex@saber btop]$ grep -nR TESTFLAGS
Makefile:42:#? Any flags added to TESTFLAGS must not contain whitespace for the testing to work
Makefile:43:override TESTFLAGS := -fexceptions -fstack-clash-protection -fcf-protection
Makefile:45:	override TESTFLAGS += -fstack-protector
Makefile:128:override GOODFLAGS := $(foreach flag,$(TESTFLAGS),$(strip $(shell echo "int main() {}" | $(CXX) -o /dev/null $(flag) -x c++ - >/dev/null 2>&1 && echo $(flag) || true)))
[nex@saber btop]$ grep -nR GOODFLAGS
Makefile:128:override GOODFLAGS := $(foreach flag,$(TESTFLAGS),$(strip $(shell echo "int main() {}" | $(CXX) -o /dev/null $(flag) -x c++ - >/dev/null 2>&1 && echo $(flag) || true)))
Makefile:134:LDCXXFLAGS			:= -pthread -D_FORTIFY_SOURCE=2 -D_GLIBCXX_ASSERTIONS $(GOODFLAGS) $(ADDFLAGS)
[nex@saber btop]$ grep -nR LDCXXFLAGS
Makefile:134:LDCXXFLAGS			:= -pthread -D_FORTIFY_SOURCE=2 -D_GLIBCXX_ASSERTIONS $(GOODFLAGS) $(ADDFLAGS)
Makefile:135:override CXXFLAGS	+= $(REQFLAGS) $(LDCXXFLAGS) $(OPTFLAGS) $(WARNFLAGS)
Makefile:136:override LDFLAGS	+= $(LDCXXFLAGS) $(OPTFLAGS) $(WARNFLAGS)
Makefile:180:	@printf "\033[1;93mLDCXXFLAGS \033[1;94m:| \033[0m$(LDCXXFLAGS)\n"
Makefile:181:	@printf "\033[1;95mCXXFLAGS   \033[1;92m+| \033[0;37m\$$(\033[92mREQFLAGS\033[37m) \$$(\033[93mLDCXXFLAGS\033[37m) \$$(\033[94mOPTFLAGS\033[37m) \$$(\033[91mWARNFLAGS\033[37m) $(OLDCXX)\n"
Makefile:182:	@printf "\033[1;95mLDFLAGS    \033[1;92m+| \033[0;37m\$$(\033[93mLDCXXFLAGS\033[37m) \$$(\033[94mOPTFLAGS\033[37m) \$$(\033[91mWARNFLAGS\033[37m) $(OLDLD)\n"
[nex@saber btop]$ 

As you can see, cf-protections stems from TESTFLAGS and propagates through GOODFLAGS to LDCXXFLAGS. As far as I can tell, GOODFLAGS is actually populated only with flags which can compile, so if that flag somehow makes it into GOODFLAGS even though the program doesn't build with that flag enabled, this might be a bug with upstream's build system.

We don't tamper with TESTFLAGS in the ebuild, so there isn't much of a reason why something in our ebuild should be the cause for the issue. Have you actually set CXX=i686-gentoo-linux-musl-g++ when running the build outside of the ebuild manually?

As a workaround, setting TESTFLAGS= in the emake call should resolve the issue as it just drops all those TESTFLAGS completely.
Comment 3 immolo 2022-12-22 14:20:37 UTC
I think I might have had an oversight in this that you highlighted, let me recreate the test as this might be an upstream issue after all.

Worse case if they don't think it then I'll submit my patch with an updated ebuild to detect i486 and i586 for you to go over so at least Gentoo users don't have to worry about this.

(Might take a few days talking to people over the holidays so I'll update as soon as I can)
Comment 4 immolo 2022-12-22 17:50:10 UTC
Ok, seems like the way I setup the system caused this and not the ebuild after you pointed another hint to me.

I'll check i586 before closing but for now don't waste your time as I think this is upstream.
Comment 5 Adrian Schollmeyer 2022-12-25 10:18:48 UTC
If you create an upstream issue about this matter, please send a link to it here. Then, I can have a look at the issue and backport the fix.
Comment 6 Adrian Schollmeyer 2023-02-17 16:29:31 UTC
Any news on this matter?
Comment 7 immolo 2023-02-18 18:45:56 UTC
Sorry I thought I added the upstream for you to track as well.