Here's an ebuild for cgilib-0.5, which is required to build soon to come rrdtool 1.2 Reproducible: Always Steps to Reproduce: 1. 2. 3.
Created attachment 55972 [details] Ebuild
Frederic, a few comments regarding your ebuild. - src_unpack() is unnecessary since it doesn't do anything. - there are some missing variables (SLOT and IUSE). - probably want to use dolib.a over dolib for static archives. If you haven't already checkout the Gentoo Developer Handbook (http://www.gentoo.org/proj/en/devrel/handbook/handbook.xml). Besides the above-mentioned issues, the ebuild looks great. Can you attach an updated version? Thanks.
Created attachment 55982 [details] Ebuild (corrected) Ebuild corrected : - src_unpack() was removed - SLOT and IUSE variables were added - dolib.a used instead of dolib
Ok, a few other things that I should've noticed the first go, but didn't: KEYWORDS on new packages (or version bumps) must be ~arch and only for those archs on which you have actually tested. Because this is a dep of the new rrdtool, I have to CC all archs for which rrdtool is KEYWORD'd so that they can test it and mark it ~arch accordingly. The second thing is that the inherit eutils is unnecessary since there's nothing in the ebuild from eutils. Don't worry about attaching an updated ebuild as I have already fixed them and am about to commit.
In CVS. CC'd archs: this package is a dependency of the latest version of net-analyzer/rrdtool (see bug 88698). Please test and mark ~arch.
cookies.c:23:17: cgi.h: No such file or directory ^^ Is there a dependancy missing? Compilation fails looking for this.
Oops, no I used emake CFLAGS=${CFLAGS} which overrode the -I. in the Makefile's CFLAGS. 'Tis fixed. Sorry about that.
Marked ~ppc.
It builds on sparc. Do we have any test cases to confirm functionality?
> It builds on sparc. Do we have any test cases to confirm functionality? The latest rrdtool uses it (which of course I can't commit until everyone keywords it). The best I can give you for a test case is the ebuild in my overlay, http://butsugenjitemple.org/~ka0ttic/overlay/net-analyzer/rrdtool/.
Unfortunately that doesn't build for me with the tcltk useflag enabled as tclrrd.c cannot find rrd_tool.h and rrd_format.h when compiling.
I've made another rrdtool 1.2.0-rc8 ebuild here : http://bugs.gentoo.org/show_bug.cgi?id=88698 - rd_tool.h and rrd_format.h are located in $(top_srcdir) - librrd_private.a doesn't seem to be needed anymore It builds fine with USE="tcltk" Regards, Fr
I've made another rrdtool 1.2.0-rc8 ebuild here : http://bugs.gentoo.org/show_bug.cgi?id=88698 - rd_tool.h and rrd_format.h are located in $(top_srcdir) - librrd_private.a doesn't seem to be needed anymore It builds fine with USE="tcltk" Regards, Frédéric
New ebuild worked well, cgilib is now ~sparc'd.
amd64/hppa/ia64 marked
~alpha keyworded.
Hi all rrdtool 1.2.0 was released yesterday : http://people.ee.ethz.ch/~oetiker/webtools/rrdtool/newin12.txt I've submitted an ebuild for it : http://bugs.gentoo.org/show_bug.cgi?id=88698
can we close this? because cgilib 0.5 is in portage ...
Already in Portage.
