Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 88684 - rdesktop-1.4.0 builds with debugging code when USE -debug
Summary: rdesktop-1.4.0 builds with debugging code when USE -debug
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Chris Gianelloni (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-11 01:01 UTC by Andreas Kling
Modified: 2005-04-14 05:58 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated ebuild that fixes problem (rdesktop-1.4.0-r1.ebuild,1.02 KB, text/plain)
2005-04-11 01:03 UTC, Andreas Kling
Details
Patch configure to respect --without (rdesktop-1.4.0-configure-with_arg.patch,1.70 KB, patch)
2005-04-11 05:20 UTC, Richard Brown (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2005-04-11 01:01:28 UTC
When running rdesktop-1.4.0, a lot of debugging information is printed on stdout, even though I didn't have USE=debug set when building it.
The ebuild generates either a --with-debug or --without-debug option to rdesktop's configure script, and it seems they both enable debugging.
Until rdesktop's configure script is fixed, the ebuild will have to skip adding --without-debug.

Reproducible: Always
Steps to Reproduce:
Comment 1 Andreas Kling 2005-04-11 01:03:58 UTC
Created attachment 55961 [details]
Updated ebuild that fixes problem

Version of rdesktop ebuild that adds --with-debug for USE=debug and nothing for
USE=-debug
Comment 2 Richard Brown (RETIRED) gentoo-dev 2005-04-11 05:20:35 UTC
Created attachment 55981 [details, diff]
Patch configure to respect --without

The current configure script doens't check to see if --with-debug=no or if
--with-ipv6=no, this patch fixes that. I'll send a patch to configure.ac
upstream.
Comment 3 Nico Baggus 2005-04-11 14:16:25 UTC
the --without is not honoured by configure in rdesktop.

By just removing the --without-debug, 

like in the ebuild above it works.
Comment 4 Richard Brown (RETIRED) gentoo-dev 2005-04-14 01:15:23 UTC
I sent a configure.ac patch upstream, this has been added to the rdesktop cvs, so those configure options should work correctly in any future versions.

http://cvs.sourceforge.net/viewcvs.py/rdesktop/rdesktop/configure.ac?rev=1.15&view=log
Comment 5 Chris Gianelloni (RETIRED) gentoo-dev 2005-04-14 04:16:48 UTC
Yeah, I saw that on the rdesktop-devel list... good job, man!

I'll get this added today when I get to work.
Comment 6 Chris Gianelloni (RETIRED) gentoo-dev 2005-04-14 05:58:55 UTC
Added to CVS... thanks again