Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 88454 - www-client/surfraw's cite clashes with the binary from app-text/html-xml-utils
Summary: www-client/surfraw's cite clashes with the binary from app-text/html-xml-utils
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Seemant Kulleen (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-09 04:06 UTC by James Rowe
Modified: 2005-04-19 07:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
surfraw-bump_2-0-2.patch (surfraw-bump_2-0-2.patch,1.36 KB, patch)
2005-04-09 04:07 UTC, James Rowe
Details | Diff
surfraw-std_compliant_paths.patch (surfraw-std_compliant_paths.patch,464 bytes, patch)
2005-04-09 04:09 UTC, James Rowe
Details | Diff
surfraw-std_compliant_paths.patch (surfraw-std_compliant_paths.patch,543 bytes, patch)
2005-04-09 07:35 UTC, James Rowe
Details | Diff
surfraw-bump_2-0-2.patch (surfraw-bump_2-0-2.patch,2.79 KB, patch)
2005-04-11 16:57 UTC, James Rowe
Details | Diff
surfraw-2.0.2-bbc_new_url.patch (surfraw-2.0.2-bbc_new_url.patch,877 bytes, patch)
2005-04-11 16:58 UTC, James Rowe
Details | Diff
surfraw-2.0.2-gentoo_pkg_tools.patch (surfraw-2.0.2-gentoo_pkg_tools.patch,1.27 KB, patch)
2005-04-11 16:59 UTC, James Rowe
Details | Diff
surfraw-2.0.2-rhyme_new_url.patch (surfraw-2.0.2-rhyme_new_url.patch,796 bytes, patch)
2005-04-11 16:59 UTC, James Rowe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Rowe 2005-04-09 04:06:49 UTC
www-client/surfraw's cite command clashes with the cite command from
app-text/html-xml-utils, initially I couldn't decide where to file the bug
but after a little thought and seeing the obvious fix I'm sure it should be
solved at surfraw's end.  Judging by the ambiguity of the command names in
surfraw I'm sure you will find many more naming collisions too, which makes
the fix described below seem more correct if that is guess^wdeductive
reasoning is true.

  Although I don't particulary like the idea as a general solution, a switch
to the Debian branch of surfraw[1] will alleviate the collisions, support
more search engines, and apparently be maintained!  Hmm, now I come to think
of it the most important feature could perhaps be the bash completion in
Debian's branch ;)

  The first attached patch just switches to the Debian tree, there is one
possible major problem; it changes the behaviour from the version currently
in portage(single frontend command with "hidden" backends).

  It should also be noted that the Debian branch is specifically defined as
in the Public Domain, so the license for the package has been changed in the
ebuild too.

  There is also a second patch attached which although I believe is The
Right Thing I'm not sure.  It moves the backend scripts to
/usr/share/surfraw/, as my reading of the FHS leads to me to believe the
files can not be considered arch dependant enough to be in /usr/lib.  YMMV,
which is why it is just a secondary patch.

  1. http://alioth.debian.org/projects/surfraw/


Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 James Rowe 2005-04-09 04:07:18 UTC
Created attachment 55747 [details, diff]
surfraw-bump_2-0-2.patch
Comment 2 James Rowe 2005-04-09 04:09:38 UTC
Created attachment 55748 [details, diff]
surfraw-std_compliant_paths.patch

As I mentioned in the description /my/ reading of the FHS suggests that /usr/
share is a more appropriate location for the backend scripts.
Comment 3 Seemant Kulleen (RETIRED) gentoo-dev 2005-04-09 05:47:40 UTC
James, this package is unmaintained in portage.  Are you willing to be maintainer-by-proxy for it?  If you shoot bugs, I'll commit your fixes.
Comment 4 James Rowe 2005-04-09 06:53:55 UTC
  I suppose that explains the lack of a metadata.xml then ;)

  And yes, imagining the other alternative is the package dying.
Comment 5 James Rowe 2005-04-09 07:35:19 UTC
Created attachment 55767 [details, diff]
surfraw-std_compliant_paths.patch

  Refresh of the [possible] FHS compliancy patch, so it catches the man page's
and completions references to the /usr/lib directory.
Comment 6 James Rowe 2005-04-11 16:55:00 UTC
  This final version, attached next, takes in all the changes from above plus:
 
  * The scripts _are_ now in /usr/share, as per the FHS spec.  The patching
has been moved to src_unpack() though.
  * The bash completion completes on package names where appropriate, using a
some what ugly method cribbed from the gentoo-bashcomp package.
  * A fix is applied which is already done upstream means BBC searches actually
work, the breakage was due to a URI change on the Beeb's website.
  * A fix is applied which is already done upstream means rhyming word searches
actually again, the breakage was due to the end of lycos' services.  The patch
changes the used server to rhymezone.
  * The usage examples are now correctly prefixes with the 'sr' command, this 
usage is a change from the previous package's method.  A note is displayed if
the user is upgrading from 1.0.7.
  * A small typo in the configuration example, which would result in silent
errors for cut 'n' paste users has been fixed.

  As far as I'm aware there are no remaining issues with this ebuild, but it 
was a lot of hassle for a simple working version bump :/
Comment 7 James Rowe 2005-04-11 16:57:15 UTC
Created attachment 56042 [details, diff]
surfraw-bump_2-0-2.patch
Comment 8 James Rowe 2005-04-11 16:58:42 UTC
Created attachment 56043 [details, diff]
surfraw-2.0.2-bbc_new_url.patch

For $FILESDIR see comment #6 for reason.
Comment 9 James Rowe 2005-04-11 16:59:14 UTC
Created attachment 56045 [details, diff]
surfraw-2.0.2-gentoo_pkg_tools.patch

For $FILESDIR see comment #6 for reason.
Comment 10 James Rowe 2005-04-11 16:59:57 UTC
Created attachment 56046 [details, diff]
surfraw-2.0.2-rhyme_new_url.patch

For $FILESDIR see comment #6 for reason.
Comment 11 Seemant Kulleen (RETIRED) gentoo-dev 2005-04-19 07:33:25 UTC
thanks for all the time you spent on this James. It's all in portage now.  The patches are in their own tarball.  I modified your ebuild a bit, so that if/when debian comes up with 2.0.2-2 it's a simple rename of the ebuild, instead of tweaking that other variable in the ebuild.