Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 88431 - non-fatal sash error if LDFLAGS set
Summary: non-fatal sash error if LDFLAGS set
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High trivial (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-04-08 23:22 UTC by Ryan Hill (RETIRED)
Modified: 2005-04-09 11:47 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Hill (RETIRED) gentoo-dev 2005-04-08 23:22:43 UTC
during linking sash will give a non-fatal error if any arb LDFLAGS are set.

|i686-pc-linux-gnu-gcc --disable-shared -static -s-Wl,-O1 -Wl,--as-needed  -o |sash sash.o cmds.o cmd_dd.o cmd_ed.o cmd_grep.o cmd_ls.o cmd_tar.o cmd_gzip.o |cmd_find.o cmd_file.o cmd_chattr.o cmd_ar.o utils.o -lz -lreadline -lncurses
|i686-pc-linux-gnu-gcc: unrecognized option '-s-Wl,-O1'

LDFLAGS in this case were "-Wl,O1 -Wl,--as-needed", so a space is needed btwn that and -s.  the simple fix is changing line 30 of sash-3.7.ebuild from

       -e "/^LDFLAGS /s:$:${LDFLAGS}:" 
to
       -e "/^LDFLAGS /s:$: ${LDFLAGS}:"
Comment 1 SpanKY gentoo-dev 2005-04-09 11:47:14 UTC
fixed in cvs, thanks