Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 884305 - [ GURU ] dwl-{0.3.1, 9999} still require gui-libs/wlroots:0/15[X(-)?]
Summary: [ GURU ] dwl-{0.3.1, 9999} still require gui-libs/wlroots:0/15[X(-)?]
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: svdm-gentoo
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-12-04 14:26 UTC by Manfred Knick
Modified: 2022-12-24 13:23 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
config.mk.patch :: for USE="X" (config.mk.patch,340 bytes, patch)
2022-12-22 17:28 UTC, Manfred Knick
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Manfred Knick 2022-12-04 14:26:31 UTC
blocking upgrade of gui-libs/wlroots
to current versions 0.16.0:0/16 or 9999:0/9999

Reproducible: Always

Steps to Reproduce:
# grep "wlroots" <...>/gui-wm/dwl/dwl-*.ebuild

dwl-0.3.1.ebuild:	gui-libs/wlroots:0/15[X(-)?]
dwl-9999.ebuild:	gui-libs/wlroots:0/15[X(-)?]
Comment 1 Efe İzbudak 2022-12-04 15:28:01 UTC
(In reply to Manfred Knick from comment #0)
> blocking upgrade of gui-libs/wlroots
> to current versions 0.16.0:0/16 or 9999:0/9999
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> # grep "wlroots" <...>/gui-wm/dwl/dwl-*.ebuild
> 
> dwl-0.3.1.ebuild:	gui-libs/wlroots:0/15[X(-)?]
> dwl-9999.ebuild:	gui-libs/wlroots:0/15[X(-)?]

Unfortunately, the version of dwl that will be using wlroots 0.16 (dwl version 0.4) is not yet released. Although there is a pre-release 0.4-rc1 and I'll be adding it to GURU soon to fix this bug.
Comment 2 Manfred Knick 2022-12-04 15:40:47 UTC
(In reply to Efe İzbudak from comment #1)

> ... Although there is a pre-release 0.4-rc1
> and I'll be adding it to GURU soon ...
  Great! Thanks in advance!

I just discovered that this holds for quite the lot of wlroots-based WM -
hikari; wayfire; even sway is just catching up with -9999 for -0.16 !

Sorry for not having spotted this situation clearly earlier.
Comment 3 Efe İzbudak 2022-12-11 10:20:10 UTC
(In reply to Manfred Knick from comment #2)
> (In reply to Efe İzbudak from comment #1)
> 
> > ... Although there is a pre-release 0.4-rc1
> > and I'll be adding it to GURU soon ...
>   Great! Thanks in advance!
> 
> I just discovered that this holds for quite the lot of wlroots-based WM -
> hikari; wayfire; even sway is just catching up with -9999 for -0.16 !
> 
> Sorry for not having spotted this situation clearly earlier.

dwl version 0.4-rc2 is added so ~amd64 dwl is not blocking wlroots:0/16 anymore.
Comment 4 Manfred Knick 2022-12-21 11:51:38 UTC
[IP-] [  ] dev-libs/wayland-9999:0

[IP-] [  ] gui-libs/egl-wayland-1.1.11-r1:0


gui-libs/wlroots-0.16.0:0/16 emerges fine:

[IP-] [  ] gui-libs/wlroots-0.16.0:0/16



gui-wm/dwl-0.4_rc2 fails:

dwl.c: In function ‘checkidleinhibitor’:
dwl.c:600:21: error: ‘bypass_surface_visibility’ undeclared (...)

dwl.c: In function ‘createpointer’:
dwl.c:953:84: error: ‘button_map’ undeclared (...)


Same results with =gui-wm/dwl-9999:0

Any quick hints / ideas ?

Kind regards
Comment 5 Efe İzbudak 2022-12-21 15:19:52 UTC
(In reply to Manfred Knick from comment #0)
> blocking upgrade of gui-libs/wlroots
> to current versions 0.16.0:0/16 or 9999:0/9999
> 
> Reproducible: Always
> 
> Steps to Reproduce:
> # grep "wlroots" <...>/gui-wm/dwl/dwl-*.ebuild
> 
> dwl-0.3.1.ebuild:	gui-libs/wlroots:0/15[X(-)?]
> dwl-9999.ebuild:	gui-libs/wlroots:0/15[X(-)?]

May I ask what patches you have set up? I remember getting this error before re-basing my patches but I can't remember off the top of my head which one it was.
Comment 6 Leonardo Hernández Hernández 2022-12-21 18:10:31 UTC
> gui-wm/dwl-0.4_rc2 fails:
> 
> dwl.c: In function ‘checkidleinhibitor’:
> dwl.c:600:21: error: ‘bypass_surface_visibility’ undeclared (...)
> 
> dwl.c: In function ‘createpointer’:
> dwl.c:953:84: error: ‘button_map’ undeclared (...)
> 
> 
> Same results with =gui-wm/dwl-9999:0
> 
> Any quick hints / ideas ?

Please update your config.h, those options were added recently
Comment 7 Manfred Knick 2022-12-22 14:01:13 UTC
Ouch ... Sorry.

Emerges fine with USE="-X".

With USE="-X", it fails linking  <-- 'xcb_disconnect' :


x86_64-pc-linux-gnu-gcc dwl.o util.o 
`pkg-config --libs wlroots wayland-server xkbcommon libinput `  
...
`pkg-config --cflags wlroots wayland-server xkbcommon libinput ` 
...
-o dwl

/usr/lib/gcc/x86_64-pc-linux-gnu/11/../../../../x86_64-pc-linux-gnu/bin/ld: dwl.o: undefined reference to symbol 'xcb_disconnect'

/usr/lib/gcc/x86_64-pc-linux-gnu/11/../../../../x86_64-pc-linux-gnu/bin/ld: /usr/lib64/libxcb.so.1: error adding symbols: DSO missing from command line


# equery list -p x11-libs/libxcb
[IP-] [  ] x11-libs/libxcb-1.15-r1:0/1.12


# grep -n xcb_disconnect *
dwl.c:2577:	xcb_disconnect(xc);


# grep -n xcb_disconnect /usr/include/xcb/xcb.h
...
530:void xcb_disconnect(xcb_connection_t *c);
...


/var/tmp/portage/gui-wm/dwl-0.4_rc2/work/dwl-0.4-rc2/config.mk :

     XWAYLAND =
     XLIBS =

     # Uncomment to build XWayland support
     #XWAYLAND = -DXWAYLAND
     #XLIBS = xcb xcb-icccm


Uncommenting these manually, emerge succeeded.
Comment 8 Manfred Knick 2022-12-22 14:49:40 UTC
Confirmation - after reboot:   Works as expected.

Seems like one missing line in src_configure() to add the XLIBS also.

Hth
Kind regards
Manfred
Comment 9 Manfred Knick 2022-12-22 17:28:35 UTC
Created attachment 844775 [details, diff]
config.mk.patch ::  for USE="X"

Temporary WORKAROUND:

Uncomment

     XWAYLAND
     XLIBS
in
     ... / dwl-0.4-rc2 / config.mk


c.f.
     https://github.com/djpohly/dwl/blob/main/config.mk
Comment 10 Manfred Knick 2022-12-23 11:04:25 UTC
(In reply to Manfred Knick from comment #8)
> Seems like one missing line in src_configure() to add the XLIBS also.


src_configure() {
	use X && append-cppflags -DXWAYLAND
	use X && append-libs -lxcb -lxcb-icccm     <-----
	tc-export CC
}

obsoletes the patch for me:

...
x86_64-pc-linux-gnu-gcc dwl.o util.o `pkg-config 
  --libs wlroots wayland-server xkbcommon libinput `  -lxcb -lxcb-icccm ...
...

[ from /var/tmp/portage/gui-wm/dwl-0.4_rc2/image/temp/build.log ]


Hth

Thanks
Comment 11 Manfred Knick 2022-12-23 11:12:26 UTC
Comment on attachment 844775 [details, diff]
config.mk.patch ::  for USE="X"

C.f. Comment 10
Comment 12 Manfred Knick 2022-12-24 13:23:35 UTC
[--O] [  ] gui-wm/dwl-0.3.1:0
[--O] [  ] gui-wm/dwl-0.4_rc2:0
[--O] [  ] gui-wm/dwl-9999:0

All work with updated wlroots.


Thanks a lot!

Closing this bug.