Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 883317 - sys-libs/libnvme-1.2-r1 -json build broken
Summary: sys-libs/libnvme-1.2-r1 -json build broken
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal minor (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-11-27 16:02 UTC by Dylan Simon
Modified: 2023-07-01 10:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Dylan Simon 2022-11-27 16:02:29 UTC
libnvme-1.2-r1 fails to build when USE=-json is disabled.  It looks like json-c may now be a required dependency, as it has required: true in https://github.com/linux-nvme/libnvme/blob/v1.2/meson.build#L58 so maybe this USE flag should just be removed?

Reproducible: Always

Steps to Reproduce:
USE=-json emerge sys-libs/libnvme
Actual Results:  
>>> Configuring source in /tmp/portage/sys-libs/libnvme-1.2-r1/work/libnvme-1.2 ...
meson setup --libdir lib64 --localstatedir /var/lib --prefix /usr --sysconfdir /etc --wrap-mode nodownload --build.pkg-config-path /usr/share/pkgconfig --pkg-config-path /usr/share/pkgconfig --native-file /tmp/portage/sys-libs/libnvme-1.2-r1/temp/meson.x86_64-pc-linux-gnu.amd64.ini -Db_pch=false -Dwerror=false --buildtype plain -Dpython=false /tmp/portage/sys-libs/libnvme-1.2-r1/work/libnvme-1.2 /tmp/portage/sys-libs/libnvme-1.2-r1/work/libnvme-1.2-build
The Meson build system
Version: 0.63.3
Source dir: /tmp/portage/sys-libs/libnvme-1.2-r1/work/libnvme-1.2
Build dir: /tmp/portage/sys-libs/libnvme-1.2-r1/work/libnvme-1.2-build
Build type: native build
Project name: libnvme
Project version: 1.2
C compiler for the host machine: x86_64-pc-linux-gnu-gcc (gcc 11.3.0 "x86_64-pc-linux-gnu-gcc (Gentoo 11.3.0 p7) 11.3.0")
C linker for the host machine: x86_64-pc-linux-gnu-gcc ld.bfd 2.38
Host machine cpu family: x86_64
Host machine cpu: x86_64
C++ compiler for the host machine: x86_64-pc-linux-gnu-g++ (gcc 11.3.0 "x86_64-pc-linux-gnu-g++ (Gentoo 11.3.0 p7) 11.3.0")
C++ linker for the host machine: x86_64-pc-linux-gnu-g++ ld.bfd 2.38
Found pkg-config: /usr/bin/x86_64-pc-linux-gnu-pkg-config (1.8.0)
Did not find CMake 'cmake'
Found CMake: NO
Run-time dependency json-c found: NO (tried pkgconfig and cmake)
Looking for a fallback subproject for the dependency json-c

meson.build:56:0: ERROR: Automatic wrap-based subproject downloading is disabled



Portage 3.0.38.1 (python 3.10.8-final-0, default/linux/amd64/17.1/no-multilib, gcc-11.3.0, glibc-2.36-r5, 5.15.75-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.15.75-gentoo-x86_64-Intel-R-_Xeon-R-_Gold_6234_CPU_@_3.30GHz-with-glibc2.36
KiB Mem:   196688384 total, 195632068 free
KiB Swap:   26861888 total,  26861888 free
Timestamp of repository gentoo: Sat, 26 Nov 2022 23:45:01 +0000
Head commit of repository gentoo: d6ccbc069aee2e5fef977ff0fc6c0d13e231ee4d
Head commit of repository dylex: 7a628dba81fa28b35cc486b326d6f228bbf39490

sh bash 5.1_p16-r2
ld GNU ld (Gentoo 2.38 p4) 2.38
app-misc/pax-utils:        1.3.5::gentoo
app-shells/bash:           5.1_p16-r2::gentoo
dev-lang/perl:             5.34.1-r4::gentoo
dev-lang/python:           3.10.8_p3::gentoo, 3.11.0_p2::gentoo
dev-util/meson:            0.63.3::gentoo
sys-apps/baselayout:       2.9::gentoo
sys-apps/openrc:           0.45.2-r1::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-devel/autoconf:        2.71-r5::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.38-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/gcc:             11.3.0::gentoo
sys-devel/gcc-config:      2.8::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.15-r3::gentoo (virtual/os-headers)
sys-libs/glibc:            2.36-r5::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.us.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-extra-opts:
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24

dylex
    location: /usr/local/portage
    sync-type: git
    sync-uri: https://github.com/dylex/portage
    masters: gentoo

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="@FREE"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-O2 -pipe -march=native -mtune=native"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-O2 -pipe -march=native -mtune=native"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR XDG_STATE_HOME"
FCFLAGS="-O2 -pipe -march=native -mtune=native"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live candy collision-protect compress-build-logs config-protect-if-modified distlocks ebuild-locks fixlafiles installsources ipc-sandbox merge-sync multilib-strict network-sandbox news nostrip pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -pipe -march=native -mtune=native"
GENTOO_MIRRORS="https://mirrors.rit.edu/gentoo/ https://gentoo.osuosl.org/ rsync://rsync.gtlib.gatech.edu/gentoo https://mirror.csclub.uwaterloo.ca/gentoo-distfiles/"
LANG="C.UTF8"
LC_ALL="C"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en"
MAKEOPTS="-j16"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/tmp"
SHELL="/bin/bash"
USE="X acl alsa amd64 bzip2 cairo cli crypt dri examples fortran gdbm gif inotify jpeg libglvnd libtirpc ncurses nptl openmp pam pcre pdf png readline split-usr ssl svg test-rust unicode vim-syntax xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2021" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 avx512f avx512dq avx512cd avx512bw avx512vl f16c fma3 mmx mmxext pclmul popcnt rdrand sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" L10N="en" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="fbdev nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LD, LEX, LFLAGS, LIBTOOL, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2023-07-01 10:51:02 UTC
I think this is fixed in 1.5.

@@ -56,7 +57,7 @@ if get_option('json-c').disabled()
 else
     json_c_dep = dependency('json-c',
                             version: '>=0.13',
-                            required: true,
+                            required: get_option('json-c'),
                             fallback : ['json-c', 'json_c_dep'])
 endif