Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 878475 - dev-libs/libpcre2: Build with large-file support
Summary: dev-libs/libpcre2: Build with large-file support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: lfs-tracker
  Show dependency tree
 
Reported: 2022-10-27 20:38 UTC by Matt Turner
Modified: 2022-10-28 02:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Turner gentoo-dev 2022-10-27 20:38:29 UTC 
Noticed on CrOS that libpcre2 builds without large-file support.

Adding append-lfs-flags is sufficient to workaround it. Soap suggested upstreaming a change to add AC_SYS_LARGEFILE.
Comment 1 Matt Turner gentoo-dev 2022-10-27 20:39:41 UTC 
The CrOS QA warning is

> 22:23:08.790  * QA Notice: The following files were not built with LFS support:
> 22:23:08.811  *   Please see https://issuetracker.google.com/201531268 for details.
> 22:23:08.832  * mmap /usr/lib/libpcre2-16.so.0.11.0
> 22:23:08.837  * mmap /usr/lib/libpcre2-8.so.0.11.0
> 22:23:08.842  * getrlimit,setrlimit,fopen /usr/bin/pcre2test
> 22:23:08.848  * fopen,stat,readdir /usr/bin/pcre2grep
> 22:23:08.866  * Full build files:
> mmap /build/arm-generic/tmp/portage/dev-libs/libpcre2-10.40/work/pcre2-10.40-.arm/src/.libs/libpcre2_16_la-pcre2_jit_compile.o
> mmap /build/arm-generic/tmp/portage/dev-libs/libpcre2-10.40/work/pcre2-10.40-.arm/src/.libs/libpcre2_8_la-pcre2_jit_compile.o
> getrlimit,setrlimit,fopen /build/arm-generic/tmp/portage/dev-libs/libpcre2-10.40/work/pcre2-10.40-.arm/src/pcre2test-pcre2test.o
> fopen,stat,readdir /build/arm-generic/tmp/portage/dev-libs/libpcre2-10.40/work/pcre2-10.40-.arm/src/pcre2grep-pcre2grep.o
> mmap /build/arm-generic/tmp/portage/dev-libs/libpcre2-10.40/work/pcre2-10.40-.arm/.libs/libpcre2-16.so.0.11.0
> getrlimit,setrlimit,fopen /build/arm-generic/tmp/portage/dev-libs/libpcre2-10.40/work/pcre2-10.40-.arm/.libs/pcre2test
> mmap /build/arm-generic/tmp/portage/dev-libs/libpcre2-10.40/work/pcre2-10.40-.arm/.libs/libpcre2-8.so.0.11.0
> fopen,stat,readdir /build/arm-generic/tmp/portage/dev-libs/libpcre2-10.40/work/pcre2-10.40-.arm/.libs/pcre2grep
Comment 2 Matt Turner gentoo-dev 2022-10-28 02:44:25 UTC 
commit 69fa0da881f7a33a0d94123dd5b2ba888d9c7912
Author: Matt Turner <mattst88@gentoo.org>
Date:   Thu Oct 27 16:11:59 2022 -0400

    dev-libs/libpcre2: Enable LFS support
    
    pcre2grep switches to using LFS-capable functions:
    
            fopen   -> fopen64
            gzopen  -> gzopen64
            readdir -> readdir64
            stat    -> stat64
    
    Signed-off-by: Matt Turner <mattst88@gentoo.org>
    Closes: https://github.com/gentoo/gentoo/pull/27993
    Signed-off-by: Sam James <sam@gentoo.org>