Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 878125 - app-backup/borgmatic add bashcompletions
Summary: app-backup/borgmatic add bashcompletions
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Marek Szuba (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-10-23 21:08 UTC by Jonas Stein
Modified: 2022-12-02 09:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jonas Stein gentoo-dev 2022-10-23 21:08:00 UTC
bash completion is generated by borgmatic itself in order to keep the information at one place for the upstream dev.

I think it should be no problem for us

They do:

sudo su -c "borgmatic --bash-completion > $(pkg-config --variable=completionsdir bash-completion)/borgmatic"

https://torsion.org/borgmatic/docs/how-to/set-up-backups/#niceties

Reproducible: Always
Comment 1 Marek Szuba (RETIRED) archtester gentoo-dev 2022-11-01 12:54:54 UTC
Having thought about and played with it for some time, I really am not besotted with the idea of making an ebuild execute the code it is in the process of being installed. It might be as simple as a bit of messing around with PYTHONPATH but it feels to me like tempting edge cases.

I'd rather just have the users deploy up-to-date rules by hand as per upstream documentation.
Comment 2 Jonas Stein gentoo-dev 2022-11-14 12:34:08 UTC
Reopening, because I think there are also other solutions possible.
Executing the code during installation is just one way to go. 

One could also generate the bashcompletion file and add it statically via files or as separate download from devspace.
Comment 3 Marek Szuba (RETIRED) archtester gentoo-dev 2022-12-02 09:45:11 UTC
If you have any patches reliably implementing in-ebuild generation of the bashcomp file, I'll gladly to incorporate them. Conversely, I'll be happy to hand over borgmatic maintenance to you if the best that can be done is to manually update the bashcomp file in FILESDIR or on the Web every time a new release comes out. In the meantime, won't fix. Not CAN'T fix, WON'T fix - I am sorry but for me the costs of supporting this greatly outweigh the benefits.