877351 – dev-python/requests-2.28.1: does test-rust flag requires test flag?

Bug 877351 - dev-python/requests-2.28.1: does test-rust flag requires test flag?

Summary: dev-python/requests-2.28.1: does test-rust flag requires test flag?

Status:	RESOLVED INVALID

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Python Gentoo Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2022-10-16 21:52 UTC by Alexander Kurakin
Modified:	2022-12-30 00:07 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alexander Kurakin 2022-10-16 21:52:12 UTC

Does test-rust flag requires test flag? Seems like so.

Comment 1 Sam James archtester

2022-10-16 21:53:16 UTC

test-rust is a hack to allow us to control Rust test dependencies so we can mask it on various arches.

Enabling it/disabling it does not control whether tests are run.

so no, it doesn't require the test use flag, unless you mean "to run tests", in which case you need FEATURES=test anyway.

Comment 2 Alexander Kurakin 2022-10-16 22:06:50 UTC

Should it be turned off by default, shouldn't it?

Comment 3 Sam James archtester

2022-10-16 22:07:57 UTC

(In reply to Alexander Kurakin from comment #2)
> Should it be turned off by default, shouldn't it?

No, it's forced-on for arches which have Rust support. It does nothing unless tests are enabled (and USE=test).

If it were turned off by default, it would make running tests harder, as "FEATURES=test" would have to magically turn on USE=test-rust too.

There is no downside to it being forced on.

Comment 4 Alexander Kurakin 2022-12-30 00:07:21 UTC

Thanks!