Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 873499 - net-libs/webkit-gtk-2.38.0 USE="gstreamer" requires additional CMake arguments
Summary: net-libs/webkit-gtk-2.38.0 USE="gstreamer" requires additional CMake arguments
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-29 16:20 UTC by Johannes Penßel
Modified: 2022-12-23 00:28 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Johannes Penßel 2022-09-29 16:20:40 UTC
The ebuild for net-libs/webkit-gtk-2.38.0 enables (among others) the following two options when building the package with USE="gstreamer":

-DUSE_GSTREAMER_TRANSCODER=$(usex gstreamer)
-DUSE_GSTREAMER_WEBRTC=$(usex gstreamer)

However, the package configuration seems to ignore this:

-- Disabling USE_GSTREAMER_TRANSCODER since ENABLE_MEDIA_RECORDER is disabled.
-- Disabling USE_GSTREAMER_WEBRTC since ENABLE_WEB_RTC is disabled.

In order to activate these features correctly, the additional CMake arguments

ENABLE_WEB_RTC
ENABLE_MEDIA_RECORDER
ENABLE_MEDIA_STREAM

must be set. I have tested this with a modified ebuild in my local overlay.

Source:

https://github.com/WebKit/WebKit/blob/webkitgtk-2.38.0/Source/cmake/GStreamerChecks.cmake
Comment 1 Matt Turner gentoo-dev 2022-10-01 17:27:55 UTC
Thanks. Would you like to submit a pull request or attach a patch here?
Comment 2 Matt Turner gentoo-dev 2022-12-23 00:28:55 UTC
Hm, looking more, I'm unsure if we should enable these. In cmake/OptionsGTK.cmake I see

> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_RECORDER PRIVATE ON)
> ...
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_MEDIA_STREAM PRIVATE ON)
> ...
> WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_WEB_RTC PRIVATE ${ENABLE_EXPERIMENTAL_FEATURES})

So they're all private options, and ENABLE_WEB_RTC is controlled by the ENABLE_EXPERIMENTAL_FEATURES option.