When building firefox 102, the build fails in libwebrtc: 8 0:07.68 In file included from Unified_cpp_common_audio_gn0.cpp:101: 8 0:07.68 /tmp/portage/www-client/firefox-102.3.0/work/firefox-102.3.0/third_par ty/libwebrtc/common_audio/wav_file.cc:93:2: error: #error "Need to convert sampl es to big-endian when reading from WAV file" 8 0:07.68 93 | #error "Need to convert samples to big-endian when reading fro m WAV file" 8 0:07.68 | ^~~~~ Reproducible: Always Steps to Reproduce: 1.emerge =www-client/firefox-102.3.0 on ppc64 (or probably any big endian arch) 2. 3. Actual Results: Build fails Expected Results: Build succeeds Portage 3.0.30 (python 3.10.6-final-0, default/linux/ppc64/17.0/desktop, gcc-11.3.0, glibc-2.35-r8, 5.4.206 ppc64) ================================================================= System uname: Linux-5.4.206-ppc64-POWER9,_altivec_supported-with-glibc2.35 KiB Mem: 133525632 total, 26943232 free KiB Swap: 0 total, 0 free Timestamp of repository gentoo: Wed, 28 Sep 2022 08:30:01 +0000 Head commit of repository gentoo: 57b274532b1819b04b096a8a77fb3933fea0f1a9 sh bash 5.1_p16-r1 ld GNU ld (Gentoo 2.38 p4) 2.38 app-misc/pax-utils: 1.3.4::gentoo app-shells/bash: 5.1_p16-r1::gentoo dev-java/java-config: 2.3.1::gentoo dev-lang/perl: 5.34.1-r3::gentoo dev-lang/python: 2.7.18_p15::gentoo, 3.10.6_p2::gentoo dev-lang/rust: 1.62.1::gentoo dev-util/cmake: 3.23.3::gentoo dev-util/meson: 0.62.2::gentoo sys-apps/baselayout: 2.8::gentoo sys-apps/openrc: 0.45.2::gentoo sys-apps/sandbox: 2.29::gentoo sys-devel/autoconf: 2.13-r2::gentoo, 2.71-r1::gentoo sys-devel/automake: 1.16.5::gentoo sys-devel/binutils: 2.38-r2::gentoo sys-devel/binutils-config: 5.4.1::gentoo sys-devel/clang: 14.0.6-r1::gentoo sys-devel/gcc: 11.3.0::gentoo sys-devel/gcc-config: 2.5-r1::gentoo sys-devel/libtool: 2.4.7::gentoo sys-devel/llvm: 14.0.6-r2::gentoo sys-devel/make: 4.3::gentoo sys-kernel/linux-headers: 5.15-r3::gentoo (virtual/os-headers) sys-libs/glibc: 2.35-r8::gentoo Repositories: gentoo location: /usr/portage sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 sync-rsync-verify-max-age: 24 sync-rsync-extra-opts: sync-rsync-verify-metamanifest: yes sync-rsync-verify-jobs: 1 zeldin location: /usr/local/portage masters: gentoo crossdev location: /usr/local/portage-crossdev masters: gentoo priority: 10 pike location: /var/lib/layman/pike masters: gentoo priority: 50 ACCEPT_KEYWORDS="ppc64" ACCEPT_LICENSE="@FREE" CBUILD="powerpc64-unknown-linux-gnu" CFLAGS="-O2 -pipe -mcpu=power9" CHOST="powerpc64-unknown-linux-gnu" CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-O2 -pipe -mcpu=power9" DISTDIR="/usr/portage/distfiles" EMERGE_DEFAULT_OPTS="--autounmask" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="-O2 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe" GENTOO_MIRRORS="http://distfiles.gentoo.org" LANG="sv_SE.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j50" PKGDIR="/usr/portage/packages" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/tmp/" SHELL="/bin/tcsh" USE="X a52 aac acl alsa big-endian bluetooth branding bzip2 cairo cdda cdr ckj cli crypt cups dbus dri dts dvd dvdr elogind encode exif flac fortran gdbm gif gnutls gpm gtk gui ibm iconv icu idn ipv6 jpeg lcms libffi libglvnd libnotify lua mad mng mp3 mp4 mpeg mule multitarget ncurses nis nls nptl offensive ogg opengl openmp pam pango pcre pdf png policykit ppc64 ppds qt5 readline sdl seccomp smp spell split-usr ssl startup-notification svg theora threads tiff truetype udev udisks unicode upower usb vorbis wxwidgets x264 xattr xcb xemacs xml xv xvid zlib" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_PPC="altivec vsx vsx2 vsx3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="fbdev radeon r600" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Please attach the full build.log.
Created attachment 814915 [details] Compressed build log. Certainly.
Created attachment 814936 [details, diff] Webrtc patch from my chromium set Also, I suddenly remember fixing this issue in chromium two years ago, with this patch: https://raw.githubusercontent.com/zeldin/chromium_be/master/chromium-89.0.4389.114/webrtc.patch I'm attaching a version which has the pathnames fixed (needs to have "libwebrtc" rather than "webrtc"), making it apply cleanly to firefox 102.3.0.
Created attachment 814939 [details] Compressed second build log With the patch applied the build gets much further, but it still fails on webrtc things: 19:52.03 Unified_cpp_systemservices1.cpp:(.text._ZN7mozilla17TabCapturerWebrtcD2Ev[_ZN7mozilla17TabCapturerWebrtcD5Ev]+0x50): undefined reference to `webrtc::DesktopCapturer::~DesktopCapturer()' 19:52.03 Unified_cpp_systemservices1.cpp:(.text._ZN7mozilla11TabCapturer7OnFrameEPNS_3dom11ImageBitmapE+0x88): undefined reference to `webrtc::BasicDesktopFrame::BasicDesktopFrame(webrtc::DesktopSize)' [...] Full log attached.
Looks like the "desktop_capture" dirs are missing in the block for 'CONFIG["CPU_ARCH"] == "ppc64" and CONFIG["OS_TARGET"] == "Linux"' in third_party/libwebrtc/moz.build. They are included for e.g. 'CONFIG["CPU_ARCH"] == "arm"' and 'CONFIG["CPU_ARCH"] == "aarch64"' .
Created attachment 814942 [details, diff] Patch to add desktop capture sources for ppc64 I'm attaching a patch which adds the missing sources on ppc64. With this firefox builds. It still does not _run_, but that seems unrelated to webrtc, so better to open a new issue I think.
https://gitweb.gentoo.org/repo/gentoo.git/commit/www-client/firefox?id=eaedaa02e18debde56b1c7d54bf5345e9e289ee4
