Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 87334 - media-plugins/bmp-scrobbler ebuild with IUSE="debug"
Summary: media-plugins/bmp-scrobbler ebuild with IUSE="debug"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords:
: 87336 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-03-30 14:14 UTC by Tom Samstag
Modified: 2005-04-01 13:38 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Updated Ebuild for bmp-scrobbler (bmp-scrobbler-0.3.6-r1.ebuild,966 bytes, text/plain)
2005-03-30 14:15 UTC, Tom Samstag
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Samstag 2005-03-30 14:14:43 UTC
The media-plugins/bmp-scrobbler package hardcoded -DDEBUG=1 and -DMETA_DEBUG=1. This updated ebuild adds IUSE="debug" and if built without +debug, disables printing debug messages.

I also added ~amd64 to the keywords, obsoleting bug #86394.

BTW, I'm not sure about giving this a revision 1, but that's up to the admin who puts this into cvs.

Reproducible: Always
Steps to Reproduce:
1. Run beep-media-player with the bmp-scrobbler plugin enabled
Actual Results:  
Debug messages printed to terminal

Expected Results:  
No output to standard out/error
Comment 1 Tom Samstag 2005-03-30 14:15:30 UTC
Created attachment 54884 [details]
Updated Ebuild for bmp-scrobbler
Comment 2 Tom Samstag 2005-03-30 14:18:23 UTC
*** Bug 87336 has been marked as a duplicate of this bug. ***
Comment 3 Tony Vroon (RETIRED) gentoo-dev 2005-04-01 13:36:02 UTC
I have rewritten your USE logic as follows:

        if ! useq debug; then
                sed -i 's:-DDEBUG=1:-DDEBUG=0:' Makefile.*
                sed -i 's:-DMETA_DEBUG=1:-DMETA_DEBUG=0:' Makefile.*
                sed -i 's:^[ \t]*printf::' scrobbler.c
        fi

This is silent and only checks the state of USE-flag once.
Comment 4 Tony Vroon (RETIRED) gentoo-dev 2005-04-01 13:38:06 UTC
This is in portage as 0.3.6-r1, please give the new ebuild two hours to propagate before you sync your portage tree.

Thank you for your report.