Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 871960 - app-emulation/wine-staging-7.16 and 7.17 does not execute /dlls/winevulkan/make_vulkan
Summary: app-emulation/wine-staging-7.16 and 7.17 does not execute /dlls/winevulkan/ma...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Wine Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-19 23:04 UTC by nvaert1986
Modified: 2022-09-20 00:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description nvaert1986 2022-09-19 23:04:13 UTC
I tried applying several Vulkan patches for resolving issues with a few select games (shared-gpu-resources patches from TKG), but whenever I try to apply those patches, building the package fails. After some troubleshooting in the wine-tkg channel, it appears that the ebuild does not execute /dlls/winevulkan/make_vulkan after the ./configure phase right before the make_requests phase.

Reproducible: Always

Steps to Reproduce:
1.Apply patches related to vulkan
2.Try to emerge wine-staging-7.16 or wine-staging-7.17
Actual Results:  
An error while compiling

Expected Results:  
A compiled package

emerge --info
Portage 3.0.36 (python 3.10.6-final-0, default/linux/amd64/17.1/systemd, gcc-11.3.0, glibc-2.35-r8, 5.19.9-gentoo x86_64)
=================================================================
System uname: Linux-5.19.9-gentoo-x86_64-12th_Gen_Intel-R-_Core-TM-_i9-12900K-with-glibc2.35
KiB Mem:    65583480 total,  17991180 free
KiB Swap:    8388604 total,   8388604 free
Timestamp of repository gentoo: Mon, 19 Sep 2022 13:30:01 +0000
Head commit of repository gentoo: 3cad8dbb48c7f7f8d346d6c6642d2ca81d33d466
Timestamp of repository vifino-overlay: Mon, 12 Sep 2022 19:25:29 +0000
Head commit of repository vifino-overlay: 76ef3b2965313c356b929f0426132198700b4ce1

sh bash 5.1_p16-r1
ld GNU ld (Gentoo 2.38 p4) 2.38
app-misc/pax-utils:        1.3.5::gentoo
app-shells/bash:           5.1_p16-r1::gentoo
dev-lang/perl:             5.34.1-r3::gentoo
dev-lang/python:           3.10.6_p4::gentoo
dev-lang/rust:             1.62.1::gentoo
dev-util/cmake:            3.23.3::gentoo
dev-util/meson:            0.62.2::gentoo
sys-apps/baselayout:       2.8::gentoo
sys-apps/sandbox:          2.29::gentoo
sys-apps/systemd:          251.3::gentoo
sys-devel/autoconf:        2.13-r2::gentoo, 2.71-r1::gentoo
sys-devel/automake:        1.16.5::gentoo
sys-devel/binutils:        2.38-r2::gentoo
sys-devel/binutils-config: 5.4.1::gentoo
sys-devel/clang:           14.0.6-r1::gentoo
sys-devel/gcc:             11.3.0::gentoo
sys-devel/gcc-config:      2.5-r1::gentoo
sys-devel/libtool:         2.4.7::gentoo
sys-devel/lld:             14.0.6::gentoo
sys-devel/llvm:            14.0.6-r2::gentoo
sys-devel/make:            4.3::gentoo
sys-kernel/linux-headers:  5.18-r1::gentoo (virtual/os-headers)
sys-libs/glibc:            2.35-r8::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-jobs: 1
    sync-rsync-extra-opts: 
    sync-rsync-verify-metamanifest: yes

crossdev
    location: /var/db/repos/crossdev
    masters: gentoo

vifino-overlay
    location: /var/db/repos/vifino-overlay
    sync-type: git
    sync-uri: https://github.com/gentoo-mirror/vifino-overlay.git
    masters: gentoo

ACCEPT_KEYWORDS="amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=alderlake -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/libreoffice/program/sofficerc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=alderlake -O2 -pipe"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-march=alderlake -O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=alderlake -O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j24"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
SHELL="/bin/bash"
USE="X acl alsa amd64 bluetooth branding bzip2 cli colord crypt cryptsetup cups curl dbus designer dri ffmpeg fontforge fortran gdbm git gstreamer gtk iconv icu idn introspection ipv6 jbig jpeg kde kerberos libglvnd libtirpc lto lzma multilib ncurses networkmanager nls nptl ogg openexr opengl openmp pam pcre pgo png policykit pulseaudio python qml qt5 readline samba scanner seccomp slang sox speex split-usr sqlite ssl systemd udev unicode vala vorbis vulkan wayland webengine webp xattr xinerama xml xscreensaver xvfb zeroconf zlib zstd" ABI_X86="32 64" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" CAMERAS="ptp ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sha sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="evdev libinput" KERNEL="linux" L10N="en en-GB en-US nl" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LLVM_TARGETS="AMDGPU X86" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10" RUBY_TARGETS="ruby31" SANE_BACKENDS="escl" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EMERGE_DEFAULT_OPTS, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
Comment 1 Ionen Wolkens gentoo-dev 2022-09-19 23:32:48 UTC
This expects to be ran against a matching vk.xml which is not bundled in the wine source, it's available from vulkan-headers but in order to match it would need to be downloaded in the SRC_URI instead.

So would need a SRC_URI download and PYTHON_COMPAT handling (this is a python script), for something that's normally not needed just in case someone potentially wants to apply user patches that need it (staging does need make_requests, but not vulkan).

You may want to consider the route of just running it yourself through /etc/portage/env hooks instead, e.g.

mkdir /etc/portage/env/app-emulation &&
cat <<-EOF > /etc/portage/env/app-emulation/wine-staging
post_src_prepare() {
    some_custom_command || die "my custom command failed"
}
EOF

(try it, should get the above die message, don't need anything else -- albeit if you try to run make_vulkan you'll get a network error when it tries to download vk.xml with network sandbox)

Alternatively, app-emulation/wine-proton does run make_vulkan because it has the vk.xml already and needs this updated (odds are wine-proton already has much of the patches you'd get from tkg too, much of it originates from proton).
Comment 2 nvaert1986 2022-09-19 23:53:13 UTC
Thank you for the information. In this case the patches are not available for wine-proton unfortunately, but only for wine-staging.  The workaround should work just fine for me (as I'm not using a network sand-boxed environment)

By the way: Doesn't make_vulkan arrange the patch by itself? As in there's no download script needed?: https://github.com/wine-mirror/wine/blob/master/dlls/winevulkan/make_vulkan#L3878
Comment 3 Ionen Wolkens gentoo-dev 2022-09-20 00:05:21 UTC
Yes but we don't write ebuilds with the idea the network sandbox is disabled and download random things without going through the Manifest