Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 869485 - media-gfx/kuickshow-0.10.2 fails to compile (MUSL): imagewindow.cpp:65:10: fatal error: netwm.h: No such file or directory
Summary: media-gfx/kuickshow-0.10.2 fails to compile (MUSL): imagewindow.cpp:65:10: fa...
Status: CONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christian Gerloff
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-09-10 11:57 UTC by Agostino Sarubbo
Modified: 2022-11-27 14:19 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,121.96 KB, text/plain)
2022-09-10 11:57 UTC, Agostino Sarubbo
Details
user-patch to remove the include (remove-netwm-include.patch,492 bytes, patch)
2022-09-11 10:42 UTC, Christian Gerloff
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-09-10 11:57:49 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-gfx/kuickshow-0.10.2 fails to compile (MUSL).
Discovered on: amd64 (internal ref: tinderbox_musl)

NOTE:
This machine uses MUSL libc
Comment 1 Agostino Sarubbo gentoo-dev 2022-09-10 11:57:51 UTC
Created attachment 804451 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-09-10 11:57:52 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


/var/tmp/portage/media-gfx/kuickshow-0.10.2/work/kuickshow-0.10.2/src/imagewindow.cpp:65:10: fatal error: netwm.h: No such file or directory
FAILED: src/CMakeFiles/kdeinit_kuickshow.dir/imagewindow.cpp.o 
/var/tmp/portage/media-gfx/kuickshow-0.10.2/work/kuickshow-0.10.2/src/imagewindow.cpp:65:10: fatal error: netwm.h: No such file or directory
Comment 3 Christian Gerloff 2022-09-11 10:42:37 UTC
Created attachment 804637 [details, diff]
user-patch to remove the include
Comment 4 Christian Gerloff 2022-09-11 10:43:48 UTC
Thank you for the bug report!

I've checked my system and the file was installed with package kde-frameworks/kwindowsystem-5.96.0 (USE flags "X nls") into directory /usr/include/KF5/KWindowSystem/.
Yours is kde-frameworks/kwindowsystem-5.97.0 and the above include directory was used during the build, so it looks like that file isn't installed on your system. Since it still exists in the package repository (https://invent.kde.org/frameworks/kwindowsystem/-/tree/master/src/platforms/xcb) I don't think it was removed in 5.97.

That being said, I believe that this particular include file is unnecessary. I couldn't find any reference to the NET* classes in KuickShow and after removing it the application still compiles normally.
I've created a user-patch that you can put in /etc/portage/patches/media-gfx/kuickshow/ which removes that include during the installation. If it works for you as well, I'd push it upstream.
Comment 5 Andreas Sturmlechner gentoo-dev 2022-11-06 11:48:41 UTC
Christian, this is a tinderbox bug - the machine will not care about a user patch. ;)

If it is not needed, the header should be dropped upstream. I've checked with the branch linked in bug 880043 and the include still exists there.
Comment 6 Christian Gerloff 2022-11-27 14:16:25 UTC
(In reply to Andreas Sturmlechner from comment #5)
> Christian, this is a tinderbox bug - the machine will not care about a user
> patch. ;)
> 
> If it is not needed, the header should be dropped upstream. I've checked
> with the branch linked in bug 880043 and the include still exists there.

Thank you Andreas, I wasn't aware of this.
I've pushed a commit to upstream that removes the header file and I'll create a new release for Gentoo next weekend.
Comment 7 Andreas Sturmlechner gentoo-dev 2022-11-27 14:19:30 UTC
No need to hurry with a release, unless you find the release work trivial anyway - MUSL users are used to some extent of pain with having to patch all kinds of packages. ;)

For Gentoo, a revbump will do it as well, and then looking forward to a new release where we can get rid of imlib1 :)