Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 868468 - dev-lang/tcl: consider using threads by default (IUSE="+threads")
Summary: dev-lang/tcl: consider using threads by default (IUSE="+threads")
Status: UNCONFIRMED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: TCL/TK Project
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 868336
  Show dependency tree
 
Reported: 2022-09-04 17:38 UTC by Holger Hoffstätte
Modified: 2022-09-13 06:50 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Holger Hoffstätte 2022-09-04 17:38:32 UTC
As per #868369 consider enabling thread support unconditionally and remove "threads" from IUSE.


Reproducible: Always
Comment 1 Holger Hoffstätte 2022-09-11 15:37:31 UTC
This affects:
dev-tcltk/expect
dev-tcltk/thread
net-analyzer/sguil-client
net-analyzer/sguil-sensor

The two sguil packages require -threads, but at least sguil-sensor is already masked/last-rited due to severe bugs. Not sure what to do with sguil-client; probably dead as well (no upstream activity for several years).
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-11 15:47:42 UTC
Can I suggest the titles for some of these bugs where you're unsure be "re-evaluate USE=threads" or similar?
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-11 20:00:43 UTC
From Fedora's changelog for their RPM/spec file (https://src.fedoraproject.org/rpms/tcl/blob/rawhide/f/tcl.spec):
"""
* Fri Jun 13 2014 Jaroslav Škarvada <jskarvad@redhat.com> - 1:8.6.1.1-5
- Re-enabled threads (previously reported bugs are no more reproducible) 

* Wed Apr 23 2008 Marcela Maslanova <mmaslano@redhat.com> - 1:8.5.1-4
- #443246 configure with disabled threads. Threads could lead to segfaults
	of dependent programme.

* Fri Feb 17 2006 David Cantrell <dcantrell@redhat.com> - 8.4.12-4
- Enable threads (#181871)
 
* Thu Jul 19 2001 Adrian Havill <havill@redhat.com>
[...]
- revert --enable-threads, linux is (still) not ready (yet) (bug 49251)
	
* Sun Jul  8 2001 Adrian Havill <havill@redhat.com>
[...]
- reenable threads which seem to work now

* Fri Jun  2 2000 Jeff Johnson <jbj@redhat.com>
[...]
- revert --enable-threads, linux is not ready (yet) (#11789).

* Sat Mar 18 2000 Jeff Johnson <jbj@redhat.com>
- configure with --enable-threads (experimental).
"""

And in Gentoo:
"""
commit 1dd8db9579a3862915cde4d3bdbf7fe862dd424a
Author: Justin Lecher <jlec@gentoo.org>
Date:   Mon Jan 20 07:34:31 2014 +0000

    dev-lang/tcl: Drop old; drop notification about threading support in favour of USE deps, #498612

    Package-Manager: portage-2.2.8/cvs/Linux x86_64
    Manifest-Sign-Key: 0xB9D4F231BD1558AB!

commit 991debf397a9bd92c43586c7d4c1236c64e4dd3d
Author: Ian Leitch <port001@gentoo.org>
Date:   Tue Apr 20 00:52:21 2004 +0000

    Enable threads with local USE flag 'threads'. #2024
"""

1. Fascinating -- what a history!
2. Fedora do have it enabled since 2014.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-09-11 20:01:42 UTC
Given the above, I think we should take some time to test all the Tcl packages with USE=threads (including removing those use deps) and see what happens.
Comment 5 Holger Hoffstätte 2022-09-11 20:17:07 UTC
The tcl configure enables threading by default, so that seems reasonable.
As for the still unmasked sguil-client I've sent mail to ajak@gentoo.org asking for clarification/masking/last-riting. That should clear the way.
Comment 6 Holger Hoffstätte 2022-09-13 06:50:02 UTC
So it turns out that sguil-client can be used without the -sensor package by connecting the GUI to a remote host (see https://bammv.github.io/sguil/index.html).

The reason why it's set to USE="-threads" is here:
https://github.com/bammv/sguil/blob/62b5dd60ca03b6093043972055c1cf36c15c65e3/server/sguild#L145

Metadata says it's maintained by netmon@gentoo.org so maybe someone on that team has an opinion whether this is still useful?