Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 867925 - Tooltips for 'stable' and 'testing' are reversed; i.e. mouseover '~amd64' and get '${PV} is stable on amd64'
Summary: Tooltips for 'stable' and 'testing' are reversed; i.e. mouseover '~amd64' and...
Status: RESOLVED FIXED
Alias: None
Product: Websites
Classification: Unclassified
Component: Packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Packages Website
URL: https://packages.gentoo.org/packages/...
Whiteboard:
Keywords:
: 802612 (view as bug list)
Depends on:
Blocks:
 
Reported: 2022-09-01 22:22 UTC by Matt Jolly
Modified: 2023-02-09 17:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Jolly gentoo-dev 2022-09-01 22:22:55 UTC
Tooltips for 'stable' and 'testing' on packages.gentoo.org are reversed; i.e. mouseover '~amd64' and get '${PV} is stable on amd64'

Example URIs:
https://packages.gentoo.org/packages/added
https://packages.gentoo.org/arches

Reproducible: Always

Steps to Reproduce:
1. Navigate to an impacted packages URI
2. Mouseover ~arch or arch

Actual Results:  
~arch is 'stable' and arch is 'testing'

Expected Results:  
~arch is 'testing' and arch is 'stable'
Comment 1 Matt Jolly gentoo-dev 2022-09-01 22:31:41 UTC
I've identified the issue in the template; will submit a PR/MR
Comment 2 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-11-15 23:16:48 UTC
*** Bug 802612 has been marked as a duplicate of this bug. ***
Comment 3 Mike Thompson 2023-02-07 22:06:47 UTC
This issue came up recently in the forums.  I note that Matt indicated he had the fix and would make a pull request.  The needed change is trivial, yet in five months this has not been acted upon.  So here is a reminder to people who might be able to address it.

As I noted in the forums, I found what I believe to be the proper repo for the code behind packages.gentoo.org, namely gitweb.gentoo.org/sites/soko.git.  This repo has seen a lot of recent activity, so I think I have the right one.  The file appears to be web/templates/packages/changedVersionRow.tmpl, and the offending lines are

<span class="label kk-keyword-stable" title="{{$.Version}} is testing on {{.}}">{{.}}</span>

and

<span class="label kk-keyword-testing" title="{{$.Version}} is stable on {{.}}">~{{.}}</span>

In both cases, there is a disparity between the word "testing" or "stable" in the title text and the corresponding CSS class name.  The first line should have "stable" in both places and the second line should have "testing".

Unfortunately, since I don't have the setup to run a test instance of the site, I am not in a position to verify any fixes.
Comment 4 Matt Jolly gentoo-dev 2023-02-07 22:47:46 UTC
FWIW https://github.com/gentoo/soko/pull/9 has the fixes and has been sitting since September.
Comment 5 Alec Warner (RETIRED) archtester gentoo-dev Security 2023-02-09 17:20:55 UTC
Any gentoo dev can commit to this repo, so its mostly finding an interested party.

Today that party can be me.

-A