864829 – =media-libs/rubberband-3.0.0 fatal error "system/Allocators.h: No such file or directory"

Bug 864829 - =media-libs/rubberband-3.0.0 fatal error "system/Allocators.h: No such file or directory"

Summary: =media-libs/rubberband-3.0.0 fatal error "system/Allocators.h: No such file o...

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Professional Audio Applications Maintainers

URL:
Whiteboard:
Keywords:	PATCH

Depends on:
Blocks:

Reported:	2022-08-10 18:03 UTC by Iade Gesso
Modified:	2023-05-23 11:17 UTC (History)
CC List:	3 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
The build log (build.log,37.66 KB, text/x-log) 2022-08-10 18:03 UTC, Iade Gesso	Details
emerge --info output (emerge --info.txt,11.44 KB, text/plain) 2022-08-10 18:04 UTC, Iade Gesso	Details
Fix compiling with jni flag enabled (rubberband-3.0.0-jni_allocators_include.patch,394 bytes, patch) 2022-08-14 20:19 UTC, Remus-Gabriel Chelu	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Iade Gesso 2022-08-10 18:03:20 UTC

Created attachment 799145 [details]
The build log

The new 3.0.0 version fails while building due to a fatal error since the JNI component do not find the "system/Allocators.h" file.

>
> FAILED: librubberband-jni.so.p/src_jni_RubberBandStretcherJNI.cpp.o 
> x86_64-pc-linux-gnu-g++ -m32 -Ilibrubberband-jni.so.p -I. -I../rubberband-3.0.0 -I../rubberband-3.0.0/rubberband -I../rubberband-3.0.0/src -I/opt/openjdk-bin-11.0.15_p10/include -I/opt/openjdk-bin-11.0.15_p10/include/linux -fdiagnostics-color=always -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wnon-virtual-dtor -Wextra -Wpedantic -std=c++11 -O3 -O2 -pipe -march=haswell -msse4 -msse4.1 -msse4.2 -mcx16 -fomit-frame-pointer -mfpmath=sse -msahf -w -flto=8 -fPIC -pthread -DHAVE_FFTW3 -DFFTW_DOUBLE_ONLY -DHAVE_LIBSAMPLERATE -DNO_THREAD_CHECKS -DNO_TIMING -DNDEBUG -DUSE_PTHREADS -DHAVE_POSIX_MEMALIGN -MD -MQ librubberband-jni.so.p/src_jni_RubberBandStretcherJNI.cpp.o -MF librubberband-jni.so.p/src_jni_RubberBandStretcherJNI.cpp.o.d -o librubberband-jni.so.p/src_jni_RubberBandStretcherJNI.cpp.o -c ../rubberband-3.0.0/src/jni/RubberBandStretcherJNI.cpp
> ../rubberband-3.0.0/src/jni/RubberBandStretcherJNI.cpp:26:10: fatal error: system/Allocators.h: No such file or directory
>   26 | #include "system/Allocators.h"
>      |          ^~~~~~~~~~~~~~~~~~~~~
>

In the attachments the complete build log and the 'emerge --info' output.


Regards,

Iade Gesso, PhD

Comment 1 Iade Gesso 2022-08-10 18:04:14 UTC

Created attachment 799147 [details]
emerge --info output

Comment 2 Iade Gesso 2022-08-13 12:15:42 UTC

A small update... the issue appears only when the jni use flag is enabled.
Disabling it makes the build process successfully complete.


Iade

Comment 3 Remus-Gabriel Chelu 2022-08-14 20:18:52 UTC

Hi, I had the same problem, and I fixed it with the patch from ArchLinux:
https://raw.githubusercontent.com/archlinux/svntogit-community/packages/rubberband/trunk/rubberband-3.0.0-jni_allocators_include.patch

For those who prefer the "sed" command:
sed -i -e "s:\#include \"system\/Allocators.h\":\#include \"..\/common\/Allocators.h\"::\" \
		src/jni/RubberBandStretcherJNI.cpp || echo "damn it!"

With either of them (the patch or the "sed" command), the "jni" flag can be raised(enabled) :) !

Comment 4 Remus-Gabriel Chelu 2022-08-14 20:19:38 UTC

Created attachment 799625 [details, diff]
Fix compiling with jni flag enabled

Comment 5 Miroslav Šulc gentoo-dev

2023-05-23 11:17:00 UTC

we don't have this version of the package anymore. i tested that with 3.2.1 and the issue did not pop up so closing this bug. if for some reason the issue still persists then please update this bug.