Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 86471 - mplayer-1.0_pre6-r1/-r2: mplayer-gcc_detection.patch breaks gcc-2.95
Summary: mplayer-1.0_pre6-r1/-r2: mplayer-gcc_detection.patch breaks gcc-2.95
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-23 23:20 UTC by Matt Taylor
Modified: 2005-05-09 08:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
mplayer-gcc_detection.patch (mplayer-gcc_detection2.patch,505 bytes, patch)
2005-03-23 23:23 UTC, Matt Taylor
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Matt Taylor 2005-03-23 23:20:35 UTC
Detected operating system: Linux
Detected host architecture: i386
Checking for cc version ... 2.95, bad
Checking for gcc version ... 2.95, bad
Checking for gcc-3.4 version ... ./configure: line 1: gcc-3.4: command not found, bad
Checking for gcc-3.3 version ... ./configure: line 1: gcc-3.3: command not found, bad
Checking for gcc-3.2 version ... ./configure: line 1: gcc-3.2: command not found, bad
Checking for gcc-3.1 version ... ./configure: line 1: gcc-3.1: command not found, bad
Checking for gcc3 version ... ./configure: line 1: gcc3: command not found, bad
Checking for gcc-3.0 version ... ./configure: line 1: gcc-3.0: command not found, bad
Checking for cc version ... 2.95, bad

*** Please downgrade/upgrade C compiler to version gcc-2.95.x or gcc-3.x! ***


on line 598 of configure it has:

   2.95.[2-9]|2.95.[2-9][-.]*|3.[0-9]|3.[0-9].[0-9])

so for gcc-2.95 the version must be >=2.95.2, but the patch truncates the gcc version to 2.95 and is interperated as 2.95.0 by configure.

Perhaps instead of truncating the version the above line could be changed to:

2.95.[2-9]|2.95.[2-9][-.]*|3.[0-9]|3.[0-9].[0-9]|3.[0-9][-.]*|3.[0-9].[0-9][-.]*)
Comment 1 Matt Taylor 2005-03-23 23:23:22 UTC
Created attachment 54314 [details, diff]
mplayer-gcc_detection.patch

updated patch for the change I sugested.  Tested on gcc-2.95.3 and gcc-3.4.3. 
I don't have any gccs with a -dumpversion of 3.x.y-z, so I can't test that it
works there.
Comment 2 Luca Barbato gentoo-dev 2005-05-09 08:44:54 UTC
Fixed in another and more general way, sorry for the delay