Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 862777 - [guru] dev-util/tokei-12.1.2 fails tests (lto): undefined reference to git_repository_free
Summary: [guru] dev-util/tokei-12.1.2 fails tests (lto): undefined reference to git_re...
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: YOSHIOKA Takuma
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2022-08-01 08:23 UTC by Agostino Sarubbo
Modified: 2024-05-02 19:35 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,395.86 KB, text/plain)
2022-08-01 08:23 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-08-01 08:23:22 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-util/tokei-12.1.2 fails tests (lto).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2
Comment 1 Agostino Sarubbo gentoo-dev 2022-08-01 08:23:25 UTC
Created attachment 796516 [details]
build.log

build log and emerge --info
Comment 2 Agostino Sarubbo gentoo-dev 2022-08-01 08:23:26 UTC
Error(s) that match a know pattern in addition to what has been reported in the summary:


          /usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/../../../../x86_64-pc-linux-gnu/bin/ld: /var/tmp/portage/dev-util/tokei-12.1.2/work/tokei-12.1.2/target/release/deps/tokei-b6709f8a933dc99a.git2-e1cbda9cdc1faa8d.git2.51fa208f-cgu.11.rcgu.o.rcgu.o: in function `git2::error::Error::last_error':
          /usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/../../../../x86_64-pc-linux-gnu/bin/ld: git2.51fa208f-cgu.11:(.text._ZN4git25error5Error10last_error17h0f99fcec34edc5fbE+0x150): undefined reference to `git_error_last'
          /usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/../../../../x86_64-pc-linux-gnu/bin/ld: git2.51fa208f-cgu.11:(.text._ZN4git25error5Error10last_error17h0f99fcec34edc5fbE+0x1a2): undefined reference to `git_error_clear'
          /usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/../../../../x86_64-pc-linux-gnu/bin/ld: libgit2_sys.a797284e-cgu.0:(.text._ZN3std4sync4once4Once9call_once28_$u7b$$u7b$closure$u7d$$u7d$17h9a9d4a3f5b948b50E.llvm.13625299658111491942+0x47): undefined reference to `git_error_last'
          /usr/lib/gcc/x86_64-pc-linux-gnu/12.1.1/../../../../x86_64-pc-linux-gnu/bin/ld: tokei.72eb05a3-cgu.8:(.text._ZN4git24repo10Repository4init17h37bbcd5571d1815aE+0x217): undefined reference to `git_repository_init_ext'
          git2.51fa208f-cgu.11:(.text._ZN4git25error5Error10last_error17h0f99fcec34edc5fbE+0x38): undefined reference to `git_error_last'
          libgit2_sys.a797284e-cgu.0:(.text._ZN3std4sync4once4Once9call_once28_$u7b$$u7b$closure$u7d$$u7d$17h9a9d4a3f5b948b50E.llvm.13625299658111491942+0x15): undefined reference to `git_libgit2_init'
          tokei.72eb05a3-cgu.7:(.text._ZN5tokei5utils2fs5tests13custom_ignore17h4379e3bb9f174c1dE+0x104): undefined reference to `git_repository_free'
          tokei.72eb05a3-cgu.7:(.text._ZN5tokei5utils2fs5tests23no_ignore_vcs_gitignore17hd7a00d23a512f44eE+0xf8): undefined reference to `git_repository_free'
          tokei.72eb05a3-cgu.7:(.text._ZN5tokei5utils2fs5tests24no_ignore_vcs_gitexclude17h2cc621bb046d28d4E+0xf8): undefined reference to `git_repository_free'
          tokei.72eb05a3-cgu.7:(.text._ZN5tokei5utils2fs5tests31no_ignore_implies_vcs_gitignore17h4ea421e686ba2203E+0xf8): undefined reference to `git_repository_free'
          tokei.72eb05a3-cgu.7:(.text._ZN5tokei5utils2fs5tests33no_ignore_dot_still_vcs_gitignore17hcbf16f577a6db2afE+0xf0): undefined reference to `git_repository_free'
          tokei.72eb05a3-cgu.8:(.text._ZN4git24repo10Repository4init17h37bbcd5571d1815aE+0x1a7): undefined reference to `git_repository_init_init_options'
error: linking with `x86_64-pc-linux-gnu-gcc` failed: exit status: 1
Comment 3 YOSHIOKA Takuma 2024-05-02 19:35:25 UTC
Now `cargo.eclass` calls `filter-lto` in `cargo_src_compile()`, so this is not reproducible.