Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 86182 - suExec strips out SSL_* environment that would generally be useful
Summary: suExec strips out SSL_* environment that would generally be useful
Status: RESOLVED UPSTREAM
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Apache Team - Bugzilla Reports
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-21 14:15 UTC by Andrew Sterling Hanenkamp
Modified: 2005-07-11 18:53 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
A better patch including both SSL_ and HTTPS= (better-patch.diff,327 bytes, patch)
2005-03-21 14:24 UTC, Andrew Sterling Hanenkamp
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andrew Sterling Hanenkamp 2005-03-21 14:15:10 UTC
Dunno if this really needs to be addressed by Gentoo or not, but it seems to me that suExec is a bit oppressive in it the fact that it disables all SSL_* variables when mod_ssl SSLOptions +StdEnvVars is in effect.

I propose that a patch be applied to suexec.c when the "ssl" USE flag is in effect. The simple patch:

--- suexec.c.old        2005-03-21 15:46:14.283263792 -0600
+++ suexec.c    2005-03-21 15:46:34.783147336 -0600
@@ -91,6 +91,9 @@
     /* variable name starts with */
     "HTTP_",
 
+    /* mod_ssl varables */
+    "SSL_",
+
     /* variable name is */
     "AUTH_TYPE=",
     "CONTENT_LENGTH=",

(to vanilla Apache 1.3.33 source) should be adequate, though it could be tightened up to be limited to just the set of variables mod_ssl produces.

Reproducible: Always
Steps to Reproduce:




Like I said, this seems to make sense to me, but there could be objections that
I'm not aware of.
Comment 1 Andrew Sterling Hanenkamp 2005-03-21 14:24:33 UTC
Created attachment 54102 [details, diff]
A better patch including both SSL_ and HTTPS=
Comment 2 Michael Stewart (vericgar) (RETIRED) gentoo-dev 2005-07-11 18:52:34 UTC
please take the patch upstream. we are trying to avoid putting minor patches in.
thanks!

resolving -> UPSTREAM
Comment 3 Michael Stewart (vericgar) (RETIRED) gentoo-dev 2005-07-11 18:53:32 UTC
clarification: minor patches as in ones that aren't anything other then
security/wont-work-on-gentoo-without-it.