Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 86176 - basc-1.5.10 with minor fixes
Summary: basc-1.5.10 with minor fixes
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Alexander Mieland
URL:
Whiteboard:
Keywords:
: 86193 (view as bug list)
Depends on:
Blocks:
 
Reported: 2005-03-21 13:13 UTC by Alexander Mieland
Modified: 2005-07-07 03:11 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
basc-1.5.10.ebuild (basc-1.5.10.ebuild,4.27 KB, text/plain)
2005-03-21 13:20 UTC, Alexander Mieland
Details
basc-1.5.10.ebuild (basc-1.5.10.ebuild,4.87 KB, text/plain)
2005-03-22 14:13 UTC, Alexander Mieland
Details
basc-1.5.10.ebuild (basc-1.5.10.ebuild,4.77 KB, text/plain)
2005-03-22 22:23 UTC, Alexander Mieland
Details
basc-1.5.10.ebuild (basc-1.5.10.ebuild,4.78 KB, text/plain)
2005-03-22 22:55 UTC, Alexander Mieland
Details
basc-1.5.10.ebuild (basc-1.5.10.ebuild,4.78 KB, text/plain)
2005-03-23 07:34 UTC, Alexander Mieland
Details
basc-1.5.10.ebuild (basc-1.5.10.ebuild,4.69 KB, text/plain)
2005-03-24 16:15 UTC, Alexander Mieland
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Mieland 2005-03-21 13:13:58 UTC
This is basc-1.5.10 with some minor fixes.

For more details, please read the changelog on:
http://www.gentoo-stats.org/index.php?c=changelog

I've cc'ed the arches that had previously marked basc, except mips, to please consider re-evaluating the package to become the stable target.

Thanks.

Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Alexander Mieland 2005-03-21 13:20:48 UTC
Created attachment 54094 [details]
basc-1.5.10.ebuild
Comment 2 Simon Stelling (RETIRED) gentoo-dev 2005-03-22 02:34:38 UTC
*** Bug 86193 has been marked as a duplicate of this bug. ***
Comment 3 Markus Rothe (RETIRED) gentoo-dev 2005-03-22 09:24:13 UTC
this finaly works on ppc64. thx dma147 for fixing this.

can this version please be added to CVS?
Comment 4 SpanKY gentoo-dev 2005-03-22 11:32:04 UTC
some notes about why this ebuild isnt ready ...

src_compile() lacks any kind of error checking and that kind of stuff shouldnt just get shunted off to /dev/null

using exeinto/doexe src_install() is a waste, just use dobin ... also, add '|| die' checks

pkg_postinst() lacks proper quoting around the $ROOT variable

basc_config() lacks proper quoting in general and all the crap involving DISTDIR and such should be removed ... if you install basc as a binary package, that will fail horribly ... really, basc_config should be moved into a 'pkg_config()' and have the user run `ebuild <basc ebuild> config` like every other normal ebuild that requires post-emerge configuration
Comment 5 Alexander Mieland 2005-03-22 14:13:04 UTC
Created attachment 54180 [details]
basc-1.5.10.ebuild

Okay, yes I thought so too...

These basc-functions in the first 1.5.10 ebuild were not from me, they were
from a developer. *g*

But well, I've changed them again as they were in 1.5.9. I've also added this
dobin-function instead of doexe and exeinto. And I've added these "|| die"
stuff to nearly all functions.

I've tested this new ebuild on x86.
Please test it again on the other arches, which are cc'ed in this bug. To mark
it with their appropriate keywords.

Thanks.
Comment 6 SpanKY gentoo-dev 2005-03-22 15:33:27 UTC
comments for new ebuild:

no point in checking return status of enew{user,group} in pkg_setup, they will call die themselves if they need to

src_compile is still wrong

src_install doesnt need || die for dodoc/dodir

pkg_postinst still lacks proper quoting for $ROOT

pkg_config still lacks proper quoting for $ROOT
Comment 7 Alexander Mieland 2005-03-22 22:23:02 UTC
Created attachment 54205 [details]
basc-1.5.10.ebuild


Very much thanks to SpanKY for his hints and comments on the ebuilds.
I've just corrected these issues too.
Comment 8 SpanKY gentoo-dev 2005-03-22 22:27:15 UTC
src_compile logic is wrong ... if USE=-x86, then it'll always fail ...

use this less ugly construct:
if use x86 ; then
    $(tc-getCC) ${CFLAGS} -o client/smt-detect client/smt-detect.c || die "smt-detect failed to build"
fi

same goes for the use x86 in src_install

also, quoting is still lacking in pkg_config()

doing a `cat file | head -n 1` is pointless, just do `head -n 1 file`
Comment 9 Alexander Mieland 2005-03-22 22:55:53 UTC
Created attachment 54208 [details]
basc-1.5.10.ebuild

and again the next version... ;)

I'm sorry that there are so much errors in these ebuilds. 
But finally we are getting a good and clear ebuild now with the help of SpanKY.
Comment 10 SpanKY gentoo-dev 2005-03-23 06:00:55 UTC
src_install still uses `doexe` instead of `dobin` at one point

pkg_config quotes *, that's not what you want ... "${var}/"*
Comment 11 Alexander Mieland 2005-03-23 07:34:09 UTC
Created attachment 54240 [details]
basc-1.5.10.ebuild

This is fixed too now...
Comment 12 Ciaran McCreesh 2005-03-24 14:24:41 UTC
* Shouldn't have the "contributed by" comment, policy says that that belongs in the ChangeLog
* It's convention to add in spaces in "foo? ( bar )" constructs
* You might want a keepdir rather than a dodir for /etc/basc
* You shouldn't combine head and sed together in pipe lists. Use sed line addresses instead (for CONFTIME and MAKETIME)
Comment 13 Alexander Mieland 2005-03-24 16:15:17 UTC
Created attachment 54395 [details]
basc-1.5.10.ebuild

Okay... this is done too...
Comment 14 Alexander Mieland 2005-03-26 03:16:35 UTC
Okay, would be fine if this ebuild can be comitted to the tree, if there are no other big problems with it...
Comment 15 Alexander Mieland 2005-04-01 13:14:27 UTC
Okay guys, how is it??? 

Are there any more problems with the ebuild? 
Or is it because you guys want to boycot me or the project? You've never liked me. Every time flames over flames from everywhere.

The ebuild for basc-1.5.9 needs over one month until it was comitted into the tree. Do you want me to also wait again one month or even longer for this 1.5.10?

Or is there no chance anymore to get it into the tree?

=====================================================================================

Guys, I've created this project 10 months ago to help *YOU*!
To provide some useful statistics over the installed packages, used systems, bugzilla(!!!), and other useful stuff.

But everything I hear from you since 10 months are flames everywhere.

=====================================================================================

I wanted to revive stats.gentoo.org. I *never* wanted to become dev!
But klieber told me, that I *have* to be dev, to get this subdomain. So I tried to become dev. But everything I hear from you is, that I only want to show off with this developer status then.

Nice.

I'm 32 years old and I think I'm old enough to be reasonable and rational enough not to show off with this developer status, because finally I never wanted to become dev, I only wanted to use this f****** subdomain.

=====================================================================================

Okay, now it is out and public.

Do what you want with this ebuild.
Comment 16 Benjamin Judas (RETIRED) gentoo-dev 2005-04-01 13:32:20 UTC
If you would probably change your general attitude instead of bitching around and creating conspiracy theories all the time, your probably would already be a dev.
Comment 17 Alexander Mieland 2005-04-01 13:43:04 UTC
lol... you don't believe yourself, do you?
When have I "bitched" around or created conspiracy theories all the time?
Comment 18 Ciaran McCreesh 2005-04-01 14:07:27 UTC
Gotta say, I agree with comment 16. The kind of thing in comment 15 is exactly why I stopped considering mentoring you.
Comment 19 gentoo_lan 2005-04-17 01:23:36 UTC
Since basc is no longer in operation you can close this bug and remove basc from the portage tree.
Comment 20 Markus Rothe (RETIRED) gentoo-dev 2005-04-17 04:00:07 UTC
as gentoo-stats.org is dead, I removed ppc64 from CC. please readd if anything changes.
Comment 21 Jan Brinkmann (RETIRED) gentoo-dev 2005-04-17 04:11:30 UTC
same for amd64
Comment 22 Thomas Bettler 2005-04-17 09:31:19 UTC
So. Would have been nice, if we had an stats project?

Who is doing the next try? - After all this flamewars
Comment 23 Marius Mauch (RETIRED) gentoo-dev 2005-04-17 10:12:51 UTC
given that the site has been shut down no point in keeping this package.
Comment 24 David Grant 2005-04-20 00:10:40 UTC
I'm disapointed that everyone couldn't act mature and sort this out, as I kind of liked the gentoo-stats/basc project. I haven't followed the whole story, but I can understand where Alexander is coming from. I submitted my first ebuild a long time ago, and it is currently the oldest unresolved bug in the sci herd right now...and it is frustrating.

Anyways, it's too bad it had to come to this.
Comment 25 Alexander Mieland 2005-04-20 02:10:04 UTC
I'm continuing this project, but not only for gentoo.
Its new name is: LiSt - Linux Statistics.
You can find it on http://www.linux-stats.org
Feel free to join #linux-stats on irc.freenode.net