Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 86102 - x11-misc/xscreensaver-4.21
Summary: x11-misc/xscreensaver-4.21
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Desktop Misc. Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-21 02:08 UTC by Ryan Finnie
Modified: 2005-06-01 00:36 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xscreensaver-4.21.ebuild (xscreensaver-4.21.ebuild,4.58 KB, text/plain)
2005-03-21 02:08 UTC, Ryan Finnie
Details
xscreensaver-4.21.ebuild (xscreensaver-4.21.ebuild,4.58 KB, text/plain)
2005-03-21 16:03 UTC, Ryan Finnie
Details
xscreensaver-4.20-r1-4.21.diff (xscreensaver-4.20-r1-4.21.diff,2.69 KB, patch)
2005-05-27 13:19 UTC, Octavio Ruiz (Ta^3)
Details | Diff
xscreensaver-4.21-norpm.patch (xscreensaver-4.21-norpm.patch,1.26 KB, patch)
2005-05-27 13:20 UTC, Octavio Ruiz (Ta^3)
Details | Diff
xscreensaver-4.21-settings.patch (xscreensaver-4.21-settings.patch,1.13 KB, patch)
2005-05-27 13:21 UTC, Octavio Ruiz (Ta^3)
Details | Diff
xscreensaver-4.21.ebuild (xscreensaver-4.21.ebuild,4.35 KB, text/plain)
2005-05-27 13:22 UTC, Octavio Ruiz (Ta^3)
Details
xscreensaver-4.21.ebuild (xscreensaver-4.21.ebuild,4.34 KB, text/plain)
2005-05-27 13:28 UTC, Octavio Ruiz (Ta^3)
Details
xscreensaver-4.21-settings.patch (xscreensaver-4.21-settings.patch,2.41 KB, patch)
2005-05-28 10:18 UTC, Octavio Ruiz (Ta^3)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryan Finnie 2005-03-21 02:08:02 UTC
It's that time again...

The RPM patch is again broken.  Replacing "rpm" with something non-existent would be just as effective, so I have replaced the patch with a simple regexp line from perl (the same could probably also be done in one command with sed, but I don't know sed as well and perl is already a prereq).  Also, the need for the fortune patch and --with-fortune have been removed upstream, so they are removed.

Please see attached ebuild.

Reproducible: Always
Steps to Reproduce:
Comment 1 Ryan Finnie 2005-03-21 02:08:41 UTC
Created attachment 54032 [details]
xscreensaver-4.21.ebuild
Comment 2 Tobias Klausmann (RETIRED) gentoo-dev 2005-03-21 11:47:49 UTC
The sed equivalent would have been:
	sed -i -e 's#rpm#rpm-GENTOO-DISABLED#g' configure

Comment 3 Ryan Finnie 2005-03-21 16:03:43 UTC
Created attachment 54116 [details]
xscreensaver-4.21.ebuild

Thanks Tobias.	Changed perl line to sed, because I have the feeling somebody
would see the perl line and the perl prereq, think the two were related, "blah
blah they included a perl requirement just for that one line?!?", etc, etc.
Comment 4 Siuchung Cheung (Clement) 2005-04-20 12:23:37 UTC
Looks like the sceensaver directory has been changed from /usr/lib/xscreensaver to /usr/libexec/xscreensaver. All of my rss_glx and fireflies screensavers suddenly become "Not Installed". Perhaps the ebuild should move all old screensavers to new location and make a sym link from old location to new location so that new sreensavers will install to the right place.
Comment 5 Peter Hyman 2005-04-27 02:07:45 UTC
After tinkering with the new default install locations, I opted for

--with-hackdir=/usr/lib/xscreensaver

Too many other programs, like kdeartwork, rss-glx, fireflies, like xscreensaver's hacks to be in /usr/lib.

One other thing I noticed is that IF xscreensaver is installed after kde, the hacks don't show in KDE's list of screensavers, BUT will execute randomly if random screensaver is selected. Recompiling kdeartwork allows all xscreensaver hacks to display. JM2C
Comment 6 Don Seiler (RETIRED) gentoo-dev 2005-05-27 13:14:24 UTC
The xscreensaver ebuilds have this conf:

--enable-hackdir=/usr/lib/xscreensaver

However I only see --with-hackdir in xscreensaver's configure --help.  I'll
change it and test now.
Comment 7 Octavio Ruiz (Ta^3) 2005-05-27 13:19:37 UTC
Created attachment 59969 [details, diff]
xscreensaver-4.20-r1-4.21.diff

* Based on xscreensaver-4.20-r1.ebuild
* Added the --with-login-manager option (gnome-base/gdm depend USE=gnome).
* Fixed xscreensaver-4.21-norpm.patch.
* Added xscreensaver-4.21-settings.patch (Sets lock timeout, Makes DPMS active
by default, For security reasons dont grab by default desktop images and set
the configuration for xscreensaver-text with gentoo stuff).
* If USE=gnome is not set but gnome-base/gdm is installed, the login-manager
option is also activated.
* --enable-hackdir doesnt exist anymore now use --with-hackdir.
* Fixed some new paths (eg. /usr/share/control-center/ ->
/usr/share/xscreensaver/config)
Comment 8 Octavio Ruiz (Ta^3) 2005-05-27 13:20:44 UTC
Created attachment 59970 [details, diff]
xscreensaver-4.21-norpm.patch
Comment 9 Octavio Ruiz (Ta^3) 2005-05-27 13:21:23 UTC
Created attachment 59971 [details, diff]
xscreensaver-4.21-settings.patch
Comment 10 Octavio Ruiz (Ta^3) 2005-05-27 13:22:09 UTC
Created attachment 59972 [details]
xscreensaver-4.21.ebuild
Comment 11 Octavio Ruiz (Ta^3) 2005-05-27 13:28:57 UTC
Created attachment 59973 [details]
xscreensaver-4.21.ebuild

* gnome-base/gdm was not a gnome atom inside RDEPEND, it was on gtk usevar.
Fixed.
* Note: xscreensaver-4.20-r1-4.21.diff do not reflect this change.
Comment 12 Don Seiler (RETIRED) gentoo-dev 2005-05-27 14:23:27 UTC
One problem is that gdm is not keyworded at all for arm.

Perhaps we can not set gdm as a DEPEND and just rely on the has_version check.
Comment 13 Don Seiler (RETIRED) gentoo-dev 2005-05-27 14:26:11 UTC
Did such and committed.  Thanks all.
Comment 14 Octavio Ruiz (Ta^3) 2005-05-28 10:18:20 UTC
Created attachment 60019 [details, diff]
xscreensaver-4.21-settings.patch

Xscreensaver always try to use gnome-terminal, if it's not installed you can
not see documentation. Changed to xterm.
Comment 15 Jakub Moc (RETIRED) gentoo-dev 2005-05-31 02:48:17 UTC
(In reply to comment #14)
> Xscreensaver always try to use gnome-terminal, if it's not installed you can
> not see documentation. Changed to xterm.

In portage, closing. Please, open a new bug.
Comment 16 Octavio Ruiz (Ta^3) 2005-06-01 00:36:31 UTC
Gggggrr...

Attachment #60342 [details, diff] Bug #94708