Bug 860846 – [guru] www-servers/hinsightd-0.9.14 fails to compile (lto): state.c:9:5: error: type of http_client_start_headers does not match original declaration [-Werror=lto-type-mismatch]

• Status: RESOLVED FIXED
• Product: GURU

[Description Agostino Sarubbo 2022-07-25 06:44:46 UTC]

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: www-servers/hinsightd-0.9.14 fails to compile (lto).
Discovered on: amd64 (internal ref: guru_tinderbox)

NOTE:
This machine uses lto with CFLAGS=-flto -Werror=odr -Werror=lto-type-mismatch -Werror=strict-aliasing

[Comment 1 Agostino Sarubbo 2022-07-25 06:44:48 UTC]

Created attachment 794141 [details]
build.log

build log and emerge --info

[Comment 2 Agostino Sarubbo 2022-07-25 06:44:49 UTC]

Error(s) that match a know pattern in addition to what has been reported in the summary:


FAILED: hin9 
/var/tmp/portage/www-servers/hinsightd-0.9.14/work/hin9-v0.9.14/src/http/client/state.c:9:5: error: type of ‘http_client_start_headers’ does not match original declaration [-Werror=lto-type-mismatch]

[Comment 3 Agostino Sarubbo 2022-07-26 09:09:10 UTC]

Here is a bit of explanation:

-Werror=lto-type-mismatch:
User to find possible runtime issues in packages. It likely means the package is unsafe to build & use with LTO.
For projects using the same identifier but with different types across different files, they must be fixed to be consistent across the codebase.

-Werror=odr:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO. C++ code must comply with the One Definition Rule (ODR) - see https://en.cppreference.com/w/cpp/language/definition#One_Definition_Rule.

-Werror=strict-aliasing:
Used to find possible runtime issues in packages. These bugs are a problem anyway but may be even worse when combined with LTO.

Workarounds:
- If upstream is friendly and still active, file a bug upstream. For emulators, codecs, games, or multimedia packages, it may be worth just applying a workaround instead, as upstreams sometimes aren't receptive to these bugs (VALID FOR ALL).
- Use the new 'filter-lto' from flag-o-matic.eclass as it's likely to be unsafe with LTO (VALID FOR lto-type-mismatch - odr).
- Fix it yourself if interested, of course (VALID FOR ALL).
- Append-flags -fno-strict-aliasing (VALID FOR strict-aliasing).
- Use memcpy() but a union is sometimes suitable too (VALID FOR strict-aliasing).
- -fstrict-aliasing is implied by -O2, so this must be addressed in some form (VALID FOR strict-aliasing).

See also: https://marc.info/?l=gentoo-dev&m=165639574126280&w=2

[Comment 4 Alexandru Campeanu 2022-07-27 09:31:01 UTC]

nice that it gives explanations

fixed in the future upstream release

[Comment 5 Agostino Sarubbo 2022-07-27 09:46:02 UTC]

Please close as fixed when there is a release in the repo

[Comment 6 Larry the Git Cow 2022-08-02 10:55:07 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=5c1cac99d855b425654b9f72dc56a4c343195905

commit 5c1cac99d855b425654b9f72dc56a4c343195905
Author:     Alexandru Campeanu <[e-mail]>
AuthorDate: 2022-07-27 16:12:45 +0000
Commit:     Alexandru Campeanu <[e-mail]>
CommitDate: 2022-07-27 16:12:45 +0000

    www-servers/hinsightd: add 0.9.15_p20220727, drop old
    
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=840047
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=860846
    
    Signed-off-by: Alexandru Campeanu <[e-mail]>

 www-servers/hinsightd/Manifest                     |  2 +-
 ...14.ebuild => hinsightd-0.9.15_p20220727.ebuild} | 22 +++++++++++++---------
 www-servers/hinsightd/hinsightd-9999.ebuild        |  6 ++++++
 3 files changed, 20 insertions(+), 10 deletions(-)