86001 – eix bash-completion shouldn't use have()

Bug 86001 - eix bash-completion shouldn't use have()

Summary: eix bash-completion shouldn't use have()

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All All

Importance:	High normal (vote)
Assignee:	Benedikt Böhm (RETIRED)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-03-20 05:26 UTC by Aaron Walker (RETIRED)
Modified:	2005-04-04 22:49 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Aaron Walker (RETIRED) gentoo-dev

2005-03-20 05:26:18 UTC

Third party completions should not use the have function as it only works if installed "globally" (in /etc/bash_completion.d) but will not work if installed locally via bash-completion-config (to ~/.bash_completion.d).

have() is really only important when you have a completion function that you only want enabled if the app is installed.  Since eix completion is only installed when eix is installed, this is unnecessary and causes "have: command not found" errors if enabled locally.

I've CC'd the upstream developer who wrote the completion.

Comment 1 Emil Beinroth 2005-03-20 06:42:53 UTC

Thanks, fixed in upstream cvs.
I noticed that the ebuild is missing "bash-completion_pkg_postinst"  in pkg_postinst.

Comment 2 Aaron Walker (RETIRED) gentoo-dev

2005-03-20 06:59:52 UTC

Ah good catch. I hadn't looked at the ebuild.  Thanks.

Comment 3 Benedikt Böhm (RETIRED) gentoo-dev

2005-04-04 22:49:44 UTC

0.2.2 is in portage => fixed