Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 8597 - fluxbox-0.1.12-r2 (added the remember patch!!)
Summary: fluxbox-0.1.12-r2 (added the remember patch!!)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement
Assignee: Matt Keadle
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2002-09-30 23:21 UTC by Jake Press
Modified: 2003-02-04 19:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
fluxbox-0.1.12-r2.ebuild (fluxbox-0.1.12-r2.ebuild,1.16 KB, text/plain)
2002-09-30 23:26 UTC, Jake Press
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jake Press 2002-09-30 23:21:21 UTC
this is r1 with the remember patch ()


---------
1) Ability to launch applications at fluxbox startup via a submenu called
'Startup' in the menu file. It's useful for those using gdm as login manager
(without .xsession).

2) Remembering of workspace, dimensions, position and other parameters via a new
submenu called 'Remember...' when you right click on the titlebar of a window.
Window settings are saved in a new file "~/.fluxbox/apps".
---------


Anyway, this is my first ebuild, i hope it helps.
Comment 1 Jake Press 2002-09-30 23:26:18 UTC
Created attachment 4336 [details]
fluxbox-0.1.12-r2.ebuild
Comment 2 Seemant Kulleen (RETIRED) gentoo-dev 2002-09-30 23:28:58 UTC
what a coincidence. LOL
Comment 3 Jochem Kossen 2002-10-01 15:31:49 UTC
This is still an experimental patch according to fluxbox.org. Please make it
optional...
Comment 4 Matt Keadle 2002-10-01 18:45:57 UTC
Awesome Jake! I've been working with the same patch.

It looks like all that's really changed is the inclusion of the new SRC_URI and
the patch command in src_unpack(). It compiles fine if we do it vanilla this
way, but I'm interested if you've built and are actually running fluxbox with
this patch. I'm getting "ghosting" on the menus that I'm working on repairing.
Are you?
Comment 5 Jake Press 2002-10-02 10:58:20 UTC
Nope, no ghosting on my end;
Perhaps try the r1 and see if you are getting ghosting?????
ive been running it for a while now too, such a nice patch.
Comment 6 Matt Keadle 2002-10-03 11:21:04 UTC
Here's what I'm getting when I apply the remember patch:

http://mkeadle.org/images/remember_patch_ghost.png

You can see my menu on the right with the 'Startup' group. This works perfectly.
On the left is the windowmenu with the 'Remember' options displayed. Those
features work perfectly as well. The problem is that most of the other options
in the windowmenu no longer match up with the correct function. For instance, to
to make a window sticky I actually have to click 'Kill Client'. Also notice that
I have two 'Close' entries in that menu.

SHRUG. I've got three other machines to test on. Maybe it's just me!

Comment 7 Jake Press 2002-10-04 23:20:30 UTC
http://www.presstec.net/Images/screenshot-6jul02.jpg
well no ghosting here! :)
Comment 8 Matt Keadle 2002-10-05 01:00:49 UTC
Ok. Please reread my last comment, perhaps more carefully this time. You'll see
that I explained that my main applications menu is working fine, it's the
Windowmenus that are having issues (the menus that appear when you right-click a
windowtitle). Again, take another look at my screenshot. There's my applications
menu with the 'Startup' group. Nothing wrong there. Now look again and the menu
spawning from the windowtitle. See the two 'Close' entries mentioned before? And
why does 'Shade' have a bullet next to it to become an expandable menu? *These*
are the issues I'm speaking about.

While you have perfected the art of the screenshot, it unfortunatly does not
help me at all. There's no view of the Windowmenu in there (the specific part
having problems), you've got no 'Startup' group (possibly because you don't see
the need for one), and your menu title says 'Fluxbox 0.1.8' while the version in
question is 0.1.12 (but menu titles aren't updated/forced automatically).

So, while you may have a fine example of a desktop, the pieces I need evidence
of are nowhere near sight! But kudos on the colors, I use a similar theme myself.

If at all possible, please take a screenshot that displays your Windowmenu (the
one produced by right-clicking a windowtitle)
Comment 9 Jake Press 2002-10-05 12:06:03 UTC
Argh!! screenshot-6jul02.jpg
thats 6 of july, thats the wrong one i linked/uploaded.
Sorry!

http://www.presstec.net/Images/Screenshot-5-oct-02.jpg

Try that one.

:)
Comment 10 Matt Keadle 2002-10-06 15:35:25 UTC
Do you have blackbox/openbox or both installed as well? Was fluxbox the last one
you compiled/installed?

I'm starting to think these issues are related to NLS. I've removed all trace of
any box from this machine, reinstalled fluxbox and the patch works fine.
Comment 11 Matt Keadle 2002-10-06 16:38:31 UTC
Well, that's it. Without any boxes emerged:

emerge fluxbox (with remember patch): works fine, no menu ghosting
emerge openbox: openbox works fine, fluxbox still works fine
emerge blackbox: black/openbox work fine, flux windowmenus start to ghost.
emerge unmerge blackbox: fluxbox windowmenu ghosting goes away

So it's a NLS thing, specifically with Blackbox. At one point I toyed with
creating a commonbox-nls package. I still don't think that's the fix, but it
helps me to remember that at one point I understood and could work with NLS!

Cheers!
Comment 12 Matt Keadle 2002-10-06 21:22:45 UTC
Ok. Done.

The problem isn't with Blackbox, it's directly with Fluxbox. As we know,
Flux/Open are essentially Black on the inside. Openbox seems smart enough to
create their own NLS setup and use that solely. Fluxbox, on the other hand,
creates it's own NLS, but if Blackbox NLS happens to be installed as well
Fluxbox will use that instead of it's own. Line 92 on src/main.cc of Fluxbox
source reads:

  NLSInit("blackbox.cat");

...but curiously, on final install the NLS catalog is actaually called
fluxbox.cat. So it's been a lot of detective work only to find out that single
line needs to be changed to:

  NLSInit("fluxbox.cat");

..and everything works great. I now have all three boxes installed with no menu
ghosting from the remember patch. I plan to send email to aLEczapKA (Fluxbox
author) and see what he knows of this, and also to update the patch itself.

The only thing really keeping me from rolling this officially is a notice
regarding this patch:

NOTICE: Do not disable tabs in Fluxbox configuration, cause you will get lots of
crushes when you try to move tabs around. You can still disable tabs for given
applications and do not notice crushes when you have tabs enabled in Fluxbox.
Comment 13 Matt Keadle 2002-10-17 15:48:37 UTC
To mention:

I've been using Fluxbox with this patch on three machines solidly since my last 
comment and have *not* had any issues. Also, I can't find notices on maillists, 
etc. that mention having the "crushing" issues described.

I'm at the point of commiting this to portage for widespread testing. If 
anything pops up, it may be possible to have a x11-wm/fluxbox and x11-
wm/fluxbox-extreme (or some suchness).

We'll see! Comments appreciated!
Comment 14 Todd Punderson 2002-10-18 04:04:27 UTC
If you have -nls in your USE it breaks. But that's probably already a given 
seeing the comments here already, but just in case. :) 
Comment 15 Matt Keadle 2002-10-26 00:20:36 UTC
Ok. It's in. It's marked as ~x86, so you'll need the proper ACCEPT_KEYWORDS to
have it show up.