Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 85964 - media-video/gxine-0.4.1 small cleanups patch
Summary: media-video/gxine-0.4.1 small cleanups patch
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Chris White (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-19 18:47 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2005-03-28 06:12 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
gxine-0.4.1.patch (gxine-0.4.1.patch,1.10 KB, patch)
2005-03-19 18:48 UTC, Diego Elio Pettenò (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-19 18:47:43 UTC 
The attached patch applied over current ebuild cleans it up a bit:

- it removes the X useflag (the configure options which was passed wasn't recognized by ./configure of gxine, gxine also depends on gtk so it needs X anyway)
- it enforces lirc useflag, which changed the dependencies but didn't actually enabled/disabled it.
- it changes the way the flags are passed to econf (directly using use_enable function instead of $myconf), it also adds --disable-dependency-tracking to speed it up a bit.
- it installs the icon as gxine.png into the hicolor structure, after renaming the icon in the .desktop file from gxine-logo.png to gxine, so that icon theme could replace it easily.

HTH, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-19 18:48:41 UTC 
Created attachment 53904 [details, diff]
gxine-0.4.1.patch
Comment 2 Chris White (RETIRED) gentoo-dev 2005-03-28 06:12:27 UTC 
Closed here.