Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 858470 - <dev-vcs/gitolite-3.6.11 <dev-vcs/gitolite-gentoo-3.6.6.1-r3: insufficient rsync access restriction
Summary: <dev-vcs/gitolite-3.6.11 <dev-vcs/gitolite-gentoo-3.6.6.1-r3: insufficient rs...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Security
Classification: Unclassified
Component: Vulnerabilities (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Gentoo Security
URL: https://github.com/sitaramc/gitolite/...
Whiteboard: B3 [noglsa]
Keywords:
Depends on: CVE-2018-16976, CVE-2018-20683
Blocks:
  Show dependency tree
 
Reported: 2022-07-16 20:52 UTC by John Helmert III
Modified: 2022-07-18 16:20 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-07-16 20:52:26 UTC
From URL:

"2019-01-08  v3.6.11 fix security issue in 'rsync' (bundle helper); see commit
                    5df2b81 for more"

The relevant commit: https://github.com/sitaramc/gitolite/commit/5df2b817255ee919991da6c310239e08c8fcc1ae

Not quite sure what the impact is, but it seems to be code injection?
Fix is in 3.6.11. gitolite is bumped, but gitolite-gentoo is
not. Seems there's tags in the upstream (our) repository, though.
Comment 1 Larry the Git Cow gentoo-dev 2022-07-16 23:44:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0a586ba2938241f100eebe58bb8b102bb9044081

commit 0a586ba2938241f100eebe58bb8b102bb9044081
Author:     Robin H. Johnson <robbat2@gentoo.org>
AuthorDate: 2022-07-16 23:44:15 +0000
Commit:     Robin H. Johnson <robbat2@gentoo.org>
CommitDate: 2022-07-16 23:44:43 +0000

    dev-vcs/gitolite-gentoo: backport v3.6.11 security fix
    
    Signed-off-by: Robin H. Johnson <robbat2@gentoo.org>
    Closes: https://bugs.gentoo.org/show_bug.cgi?id=858470

 dev-vcs/gitolite-gentoo/Manifest                   |   1 +
 .../gitolite-gentoo-3.6.6.1-r3.ebuild              | 111 +++++++++++++++++++++
 2 files changed, 112 insertions(+)
Comment 2 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-07-16 23:53:33 UTC
Please cleanup. Robin, any input about the impact?
Comment 3 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2022-07-17 00:05:22 UTC
Impact: was not enabled by default. Required enabling two separate flags, in different files ("rsync" in gitolite.rc, and then "option bundle = 1" in the gitolite-admin per-repo config; note that the original commit message only had the rsync part, and missed the bundle=1)

Gentoo infra was not impacted because "option bundle = 1" was only enabled very briefly in a single repo. 

cleanup is done
Comment 4 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2022-07-18 16:20:48 UTC
Oh, seems gitolite was handled in bug 689794. gitolite-gentoo is good now. Thanks Robin, all done!