Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 85638 - dev-util/subversion "fix" berkdb includes
Summary: dev-util/subversion "fix" berkdb includes
Status: RESOLVED INVALID
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Other (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Gentoo/BSD Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-17 06:51 UTC by Diego Elio Pettenò (RETIRED)
Modified: 2006-04-12 10:50 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
subversion-1.1.3-r1.patch (subversion-1.1.3-r1.patch,647 bytes, patch)
2005-03-17 06:52 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
db.eclass patch (db.eclass.patch,713 bytes, patch)
2005-03-20 04:26 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff
subversion-1.1.4.patch (subversion-1.1.4.patch,1.02 KB, patch)
2005-04-05 07:20 UTC, Diego Elio Pettenò (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-17 06:51:52 UTC
The attached patch applied over current ebuild "fixes" a little problem with berkdb includes. I used the quotation marks as it's not a problem for general users, but it's a real problem for fbsd users.
Little explanation:

/usr/include/db.h is a system include in freebsd.

At the moment sys-libs/db creates a link db.h which points to db4.2/db.h, and this is not good.
I have modified the eclass to skip that link, but i'm not sure for the fix as for now.
The attached patch make sure that the db.h file included by subversion is the one in db4.2 and not the system include.
This changes nothing for normal users, but makes subversion work for fbsd users.

I also removed the autoconf dying when found 2.58, as the depends states clearly 2.59.

P.S.: i've CCed pauldv as it's subversion's maintainer.

HTH, Diego
Comment 1 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-17 06:52:22 UTC
Created attachment 53700 [details, diff]
subversion-1.1.3-r1.patch
Comment 2 Paul de Vrieze (RETIRED) gentoo-dev 2005-03-20 02:32:08 UTC
I'm also the db maintainer. I'd like your suggestions how to once and for all fix the db problems. 
Comment 3 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-20 04:26:18 UTC
Created attachment 53923 [details, diff]
db.eclass patch

Good to know :)

This is the patch I used on g/fbsd, which simply removes inclues which are put
in /usr/include.
This would create troubles to packages, similarly as it does with subversion,
so they should add the right directory to the include path.
Comment 4 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-05 07:20:40 UTC
Created attachment 55356 [details, diff]
subversion-1.1.4.patch

A little more of a cleanup, removing a few $myconf lines and moved them
directly on econf call.
Comment 5 Paul de Vrieze (RETIRED) gentoo-dev 2005-04-05 07:27:52 UTC
I'll try to look at this tonight. The include files must however not be 4.2 but the ones that correspond to the db version that apr-util was build against.
Comment 6 Francisco José Cañizares Santofimia 2005-04-08 14:07:59 UTC
This bug does NOT apply just to BSD, why don't change the Product?
Thanks.
Comment 7 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-08 14:25:09 UTC
Well actually on non-bsd systems there shouldn't be too much problems with that. Main problem is that /usr/include/db.h is a system include instead of a local one which is on Linux.

The other cleanups in the patch are mainly cosmetics.

Oh, Paul if the problem is with apr, why not just modify apr-config script in apr to point to the right include path directly? This would require a pair of changes more, but should work, right?
Comment 8 Francisco José Cañizares Santofimia 2005-04-08 16:06:47 UTC
The fact is that until I've tried thr subversion-1.1.4.patch I had not been able to compile this.
Comment 9 Paul de Vrieze (RETIRED) gentoo-dev 2005-04-09 05:20:47 UTC
Diego that's right. Fransisco, this is most a problem for berkdb. But to get rid of many problems I might decide to remove the whole symlink business for the header files allthough that would require packages to be more explicit in their berkeley db header files.
Comment 10 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-04-10 22:20:20 UTC
The patch for 1.1.4 applies cleanly over 1.1.4-r1 (with offset, of course).
Comment 11 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-06-10 12:01:33 UTC
Fixed with latest version which uses apr-util (when bug #95468 will be fixed).