Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 856292 - [guru] media-sound/nulloy-0.9.3 installs pre-stripped files
Summary: [guru] media-sound/nulloy-0.9.3 installs pre-stripped files
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Vitaly Zdanevich
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qa-guru
  Show dependency tree
 
Reported: 2022-07-03 18:36 UTC by Agostino Sarubbo
Modified: 2022-07-10 10:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,238.91 KB, text/plain)
2022-07-03 18:36 UTC, Agostino Sarubbo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2022-07-03 18:36:52 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: media-sound/nulloy-0.9.3 installs pre-stripped files.
Discovered on: amd64 (internal ref: guru_ci)
Comment 1 Agostino Sarubbo gentoo-dev 2022-07-03 18:36:55 UTC
Created attachment 789989 [details]
build.log

build log and emerge --info
Comment 2 Vitaly Zdanevich 2022-07-04 05:07:05 UTC
This link it dead.

I do not understand - what is the problem? What is pre-stripped files mean? What should I fix?
Comment 3 Bernd 2022-07-04 05:40:21 UTC
(In reply to Vitaly Zdanevich from comment #2)
> I do not understand - what is the problem? What is pre-stripped files mean?
> What should I fix?

It means, the build process strips the binaries from most of the symbols. This should not be done by the build tools, because portage does it when the install phase is run to be able to support the `splitdebug` and `installsources` FEATURES.

Look for `-s` flag passed to the compiler or linker and remove it from the build files.
Comment 4 Vitaly Zdanevich 2022-07-04 06:14:02 UTC
There is no `-s` in the ebuild, I will ask the author of the Nulloy.
Comment 5 Vitaly Zdanevich 2022-07-04 06:16:06 UTC
Created issue https://github.com/nulloy/nulloy/issues/200
Comment 6 Bernd 2022-07-04 06:42:58 UTC
make[1]: Entering directory '/var/tmp/portage/media-sound/nulloy-0.9.3/work/nulloy-0.9.3/src/plugins/gstreamer'
/usr/bin/qmake5 -install qinstall -exe ../../../plugins/libplugin_gstreamer.so /var/tmp/portage/media-sound/nulloy-0.9.3/image/usr/lib64/nulloy/plugins/libplugin_gstreamer.so
strip --strip-unneeded /var/tmp/portage/media-sound/nulloy-0.9.3/image/usr/lib64/nulloy/plugins/libplugin_gstreamer.so

The qmake install target strips the binaries.
Comment 7 Bernd 2022-07-04 06:50:49 UTC
See also https://doc.qt.io/qt-5/qmake-variable-reference.html#installs on how to disable it.
Comment 8 Vitaly Zdanevich 2022-07-05 04:19:57 UTC
What can you recommend to add to the ebuild?
Comment 9 Bernd 2022-07-05 04:40:42 UTC
I would try to patch the nulloy.pro file and change CONFIG += ordered into CONFIG += ordered nostrip. Another way has been shown by the upstream dev in the issue you have opened.

Another thing, I've noticed when looking at the build log and the src/src.pri file is:

Project MESSAGE: This project is using private headers and will therefore be tied to this specific Qt module build version.
Project MESSAGE: Running this project against other versions of the Qt modules may crash at any arbitrary point.
Project MESSAGE: This is not a bug, but a result of using Qt internals. You have been warned!

and

QT += core-private

IIRC you need to add the slot operator on qtcore in that case, to ensure a rebuild is triggered on qtcore updates. But better ensure this is true by asking the qt project devs in #gentoo-qt.
Comment 10 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2022-07-05 04:44:48 UTC
What Bernd said, but also grep for examples using qmake in the gentoo repo.
Comment 11 Vitaly Zdanevich 2022-07-09 22:14:39 UTC
(In reply to Bernd from comment #9)
> I would try to patch the nulloy.pro file and change CONFIG += ordered into
> CONFIG += ordered nostrip

Tried this in this commit https://github.com/gentoo/guru/commit/ceafffcacd1fe1fe14c1e4b1ad52662f97a96eaf but after compilation I still see 

 * QA Notice: Pre-stripped files found:
 * /usr/bin/nulloy
 * /usr/lib64/nulloy/plugins/libplugin_gstreamer.so

Hm, why?
Comment 12 Bernd 2022-07-10 08:38:24 UTC
I'm not much used to qmake, it's "+=" syntax for settings and how it propagates these settings. Maybe you need to add it in other files, like src/src.pr{i,o} and/or src/plugins/plugin.pr{i,o}, src/plugins/pluginGstreamer/pluginGstreamer.pro?
The comment should just give you an idea of where to possibly start looking for potential fixes.