Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 85583 - games-fps/legends: missing menu entry and icon
Summary: games-fps/legends: missing menu entry and icon
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-16 20:42 UTC by Josh Nichols (RETIRED)
Modified: 2005-09-09 08:31 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
legends-0.4.1b-r1.ebuild (legends-0.4.1b-r1.ebuild,1.72 KB, text/plain)
2005-03-16 20:44 UTC, Josh Nichols (RETIRED)
Details
icon for legends (legends.png,4.97 KB, image/png)
2005-03-16 20:44 UTC, Josh Nichols (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Nichols (RETIRED) gentoo-dev 2005-03-16 20:42:23 UTC
There currently is not an icon or .desktop entry in /usr/share/applications

Reproducible: Always
Steps to Reproduce:
Comment 1 Josh Nichols (RETIRED) gentoo-dev 2005-03-16 20:44:19 UTC
Created attachment 53671 [details]
legends-0.4.1b-r1.ebuild

Ebuild that makes a menu entry, and creates an icon.
Comment 2 Josh Nichols (RETIRED) gentoo-dev 2005-03-16 20:44:56 UTC
Created attachment 53672 [details]
icon for legends
Comment 3 Mr. Bones. (RETIRED) gentoo-dev 2005-03-16 22:12:58 UTC
This might be a problem.  I'm not sure the icon will make it out to the mirrors because we have RESTRICT=nomirror in the ebuild since the legends archive is so large.
Comment 4 Josh Nichols (RETIRED) gentoo-dev 2005-03-16 22:21:44 UTC
Whoops, neglected to notice that.

So I'm guessing that nomirror is an all or nothing deal, and can't be done for one source versus another?

I put a copy up at http://www.rpi.edu/~nichoj/legends.png ... RPI shouldn't mind too much :)
Comment 5 Chris Gianelloni (RETIRED) gentoo-dev 2005-03-17 05:33:14 UTC
Actually, nomirror is just designed to disable automatic mirroring.  If we upload the icon file to the mirrors, it will be fetched and will stay on the mirrors.  Only RESTRICT=fetch would cause the icon to not be fetched from the mirrors, so this should work.

Josh, in the future, for trivial changes like this, a diff between the current ebuild and the new ebuild is fine, since these are minor enhancements and don't require a version bump and are usually only a line or two of changes.
Comment 6 Mr. Bones. (RETIRED) gentoo-dev 2005-03-17 07:47:23 UTC
I'd also like to point out that make_desktop_entry assumes ${PN}.png as the icon file.  If that's what's being used, there's no need to specify it explicitly.
Comment 7 Chris Gianelloni (RETIRED) gentoo-dev 2005-03-17 08:30:43 UTC
What?!

/me runs off to change a ton of make_desktop_entry lines in several packages...

*grin*
Comment 8 Chris Gianelloni (RETIRED) gentoo-dev 2005-09-09 08:31:37 UTC
Added to CVS...

...and shame on your for removing this from your RPI site... :P