Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 85431 - eutils.eclass: make_desktop_entry could be more complete in detecting categories
Summary: eutils.eclass: make_desktop_entry could be more complete in detecting categories
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: SpanKY
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-15 16:15 UTC by Josh Nichols (RETIRED)
Modified: 2005-03-16 18:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to make make_desktop_entry (eutils.diff,3.80 KB, patch)
2005-03-15 16:17 UTC, Josh Nichols (RETIRED)
Details | Diff
eutils.eclass.new (eutils.eclass.new,3.45 KB, patch)
2005-03-16 18:26 UTC, SpanKY
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Josh Nichols (RETIRED) gentoo-dev 2005-03-15 16:15:21 UTC
As it is, make_desktop_entry isn't particularly complete in determining which categories it should. As it is, it really detects games-*, net-* and app-emulation.

Reproducible: Always
Steps to Reproduce:
Comment 1 Josh Nichols (RETIRED) gentoo-dev 2005-03-15 16:17:15 UTC
Created attachment 53583 [details, diff]
patch to make make_desktop_entry

Makes make_desktop_entry a lot more complete for detecting the category for a
.desktop entry.
Comment 2 Diego Elio Pettenò (RETIRED) gentoo-dev 2005-03-15 23:59:15 UTC
Sounds pretty good to me, but just my 2 cents:
- don't add those commented-out lines, they only confuse the final code
- group similar categories in a single switch statements (I'm talking about app-editors, emacs, xemacs and vim).

Good job imho :)
Comment 3 SpanKY gentoo-dev 2005-03-16 11:00:37 UTC
the reason it only supports a few categories is because i wrote it just for game related packages, everyone else sucks ;)
Comment 4 Josh Nichols (RETIRED) gentoo-dev 2005-03-16 17:54:55 UTC
As for the commented out sections, it was because there's a variable subdir which I didn't really know what it did, but it didn't seem to do anything. Nothing seems to break with them commented out, so they probably can be removed.

As for grouping similar categories, I would have to disagree. I put them in (I hope) alphabetical order, believing that it might be slightly easier to maintain. 

So SpanKY, is would it possible to get this into eutils? I recall in another bug you mentioning that make_desktop_entry is just a bandaid for domenu... Regardless of that, I think this patch could make it a better bandaid while domenu is in the works.
Comment 5 SpanKY gentoo-dev 2005-03-16 18:26:45 UTC
Created attachment 53667 [details, diff]
eutils.eclass.new

how about this one ?
Comment 6 Josh Nichols (RETIRED) gentoo-dev 2005-03-16 18:38:27 UTC
Looks really good. Much, much cleaner than mine :)
Comment 7 SpanKY gentoo-dev 2005-03-16 18:45:13 UTC
thanks

added to cvs