Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 85268 - kdelibs khtml patch KDE bug 59701 for 3.4.0
Summary: kdelibs khtml patch KDE bug 59701 for 3.4.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo KDE team
URL: http://bugs.kde.org/show_bug.cgi?id=5...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-14 14:53 UTC by Tom Shaw
Modified: 2005-03-15 09:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
kdelibs-3.4.0-imagemap_Y_coordinates_mangled-fix.patch (kdelibs-3.4.0-imagemap_Y_coordinates_mangled-fix.patch,519 bytes, patch)
2005-03-15 09:29 UTC, Jon
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Shaw 2005-03-14 14:53:42 UTC
The "imagemap Y coordinates mangled" bug for khtml was fixed but it won't be
included until 3.4.1. I applied the patch to 3.4.0_rc1 and it works good now
when you scroll on a page and click an imagemap.

http://bugs.kde.org/show_bug.cgi?id=59701#c25

CVS commit by carewolf: 
 
 Backport of fix for #59701 
 CCBUG: 59701 
 
 
   M +5 -0      html_formimpl.cpp   1.421.2.1 
 
 
 --- kdelibs/khtml/html/html_formimpl.cpp  #1.421:1.421.2.1 
 @@ -1605,4 +1605,9 @@ void HTMLInputElementImpl::defaultEventH 
                  xPos = me->clientX()-offsetX; 
                  yPos = me->clientY()-offsetY; 
 +                KHTMLView* v = getDocument()->view(); 
 +                if ( v ) { 
 +                    xPos += v->contentsX(); 
 +                    yPos += v->contentsY(); 
 +                } 
              } 
          } 
 
 


Reproducible: Always
Steps to Reproduce:
1.
2.
3.
Comment 1 Jon 2005-03-15 09:29:08 UTC
Created attachment 53546 [details, diff]
kdelibs-3.4.0-imagemap_Y_coordinates_mangled-fix.patch

I went ahead and created a nice patch for this. I did this against the kde 3.4
final. The code that was given was not in the standard patch form, ie 3 lines
before and after the modifications. This should be easier for the devs to
include in the kde package if they want. I will go ahead and put this in the
pertty patches if it is not included. :D
Comment 2 Jon 2005-03-15 09:30:39 UTC
Comment on attachment 53546 [details, diff]
kdelibs-3.4.0-imagemap_Y_coordinates_mangled-fix.patch

I went ahead and created a nice patch for this. I did this against the kde 3.4
final. The code that was given was not in the standard patch form, ie 3 lines
before and after the modifications. This should be easier for the devs to
include in the kde package if they want. I will go ahead and put this in the
pertty patches if it is not included. :D
Comment 3 Gregorio Guidi (RETIRED) gentoo-dev 2005-03-15 09:48:07 UTC
I just committed the for kdelibs-3.4.0.
Comment 4 Gregorio Guidi (RETIRED) gentoo-dev 2005-03-15 09:52:35 UTC
...*patch for* kdelibs-3.4.0.