851822 – eend without ebegin QA check doesn't allow nested calls (was: python-utils-r1.eclass calls eend without preceding ebegin)

Bug 851822 - eend without ebegin QA check doesn't allow nested calls (was: python-utils-r1.eclass calls eend without preceding ebegin)

Summary: eend without ebegin QA check doesn't allow nested calls (was: python-utils-r1...

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Core (show other bugs)
Hardware:	All Linux

Importance:	Normal normal (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:

Duplicates (2):	843896 847040 (view as bug list)
Depends on:
Blocks:

Reported:	2022-06-14 06:47 UTC by Agostino Sarubbo
Modified:	2023-05-23 09:43 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
build.log (build.log,89.47 KB, text/plain) 2022-06-14 06:47 UTC, Agostino Sarubbo	Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Agostino Sarubbo gentoo-dev

2022-06-14 06:47:36 UTC

https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: sys-apps/qingy-1.0.0-r5 calls eend without preceding ebegin.
Discovered on: amd64 (internal ref: tinderbox)

Comment 1 Agostino Sarubbo gentoo-dev

2022-06-14 06:47:38 UTC

Created attachment 784718 [details]
build.log

build log and emerge --info

Comment 2 Mike Gilbert gentoo-dev

2022-07-11 03:54:13 UTC

Needs a fix in python-utils-r1.eclass.

Comment 3 Mike Gilbert gentoo-dev

2022-07-11 04:13:10 UTC

*** Bug 847040 has been marked as a duplicate of this bug. ***

Comment 4 Mike Gilbert gentoo-dev

2022-07-11 04:22:52 UTC

*** Bug 843896 has been marked as a duplicate of this bug. ***

Comment 5 Sam James archtester

2023-05-23 09:25:15 UTC Comment hidden (obsolete)

(In reply to Mike Gilbert from comment #2)
> Needs a fix in python-utils-r1.eclass.

I think this was actually


commit 7ff843c2cd8011c61617c8307a25db994110d93d
Author: Mike Gilbert <floppym@gentoo.org>
Date:   Mon Jun 27 14:50:34 2022 -0400

    epatch.eclass: call ebegin to balance eend

    Closes: https://bugs.gentoo.org/840963
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

*** This bug has been marked as a duplicate of bug 840963 ***

Comment 6 Sam James archtester

2023-05-23 09:25:46 UTC Comment hidden (obsolete)

commit 7ff843c2cd8011c61617c8307a25db994110d93d
Author: Mike Gilbert <floppym@gentoo.org>
Date:   Mon Jun 27 14:50:34 2022 -0400

    epatch.eclass: call ebegin to balance eend

    Closes: https://bugs.gentoo.org/840963
    Signed-off-by: Mike Gilbert <floppym@gentoo.org>

Comment 7 Sam James archtester

2023-05-23 09:35:26 UTC

I got confused by the qingy reference here, oops (which was an epatch consumer).

I'm not spotting what the issue is as of today in python-utils-r1, nor do I see a commit fixing it?

Comment 8 Sam James archtester

2023-05-23 09:39:07 UTC

Ah, I think this was fixed by https://github.com/gentoo/portage/commit/50ac4e2e3401be2410a01f7d5d7923672b57798f.