Bug 850988 – www-client/firefox-91.10.0[-clang] doesn't build (error: non-constant condition for static assertion)

• Status: RESOLVED UPSTREAM
• Product: Gentoo Linux

[Description Sebastian Melzer 2022-06-10 11:40:59 UTC]

Compilation fails with the following message, possibly a GCC bug. This is not the first version of Firefox with this problem, but the problem is still recent - according to emerge.log it was probably introduced in 91.8.0. Compilation with set clang USE-flag succeeds.

 1:30.72 /var/tmp/portage/www-client/firefox-91.10.0/work/firefox-91.10.0/dom/base/nsTreeSanitizer.cpp:635:20: error: non-constant condition for static assertion
 1:30.72   635 | static_assert(AllOf(std::begin(kURLAttributesSVG), std::end(kURLAttributesSVG),
 1:30.72       |               ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1:30.72   636 |                     [](auto aURLAttributeSVG) {
 1:30.72       |                     ~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1:30.72   637 |                       return AnyOf(std::begin(kAttributesSVG),
 1:30.72       |                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1:30.72   638 |                                    std::end(kAttributesSVG),
 1:30.72       |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~
 1:30.72   639 |                                    [&](auto aAttributeSVG) {
 1:30.72       |                                    ~~~~~~~~~~~~~~~~~~~~~~~~~
 1:30.72   640 |                                      return aAttributeSVG == aURLAttributeSVG;
 1:30.72       |                                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
 1:30.72   641 |                                    });
 1:30.72       |                                    ~~~
 1:30.72   642 |                     }));
 1:30.72       |                     ~~
 1:30.72 /var/tmp/portage/www-client/firefox-91.10.0/work/firefox-91.10.0/dom/base/nsTreeSanitizer.cpp:635:20:   in 'constexpr' expansion of 'mozilla::AllOf<const nsStaticAtom* const*, <lambda(auto:30)> >(std::begin<const nsStaticAtom* const, 2>(kURLAttributesSVG), std::end<const nsStaticAtom* const, 2>(kURLAttributesSVG), (<lambda closure object><lambda(auto:30)>{}, <lambda(auto:30)>()))'
 1:30.72 /var/tmp/portage/www-client/firefox-91.10.0/work/firefox_build/dist/include/mozilla/Algorithm.h:24:15:   in 'constexpr' expansion of 'aPred.<lambda(auto:30)>(((const nsStaticAtom*)(* aFirst)))'
 1:30.72 /var/tmp/portage/www-client/firefox-91.10.0/work/firefox-91.10.0/dom/base/nsTreeSanitizer.cpp:637:35:   in 'constexpr' expansion of 'mozilla::AnyOf<const nsStaticAtom* const*, <lambda(auto:30)>::<lambda(auto:31)> >(std::begin<const nsStaticAtom* const, 182>(kAttributesSVG), std::end<const nsStaticAtom* const, 182>(kAttributesSVG), <lambda closure object><lambda(auto:30)>::<lambda(auto:31)>{aURLAttributeSVG})'
 1:30.72 /var/tmp/portage/www-client/firefox-91.10.0/work/firefox-91.10.0/dom/base/nsTreeSanitizer.cpp:640:59: error: '((& mozilla::detail::gGkAtoms.mozilla::detail::GkAtoms::mAtoms[1541]) == 0)' is not a constant expression
 1:30.72   640 |                                      return aAttributeSVG == aURLAttributeSVG;
 1:30.73       |

Reproducible: Always

[Comment 1 Sebastian Melzer 2022-06-10 11:43:33 UTC]

Created attachment 783851 [details]
build.log (compressed)

[Comment 2 Sebastian Melzer 2022-06-10 11:45:46 UTC]

Created attachment 783854 [details]
emerge --info

[Comment 3 Sam James 2022-06-10 12:01:29 UTC]

As discussed on IRC (just commenting here so nobody else looks into it just yet in case it is this), it looks like it's caused by -fno-delete-null-pointer-checks.

[Comment 4 Sebastian Melzer 2022-06-10 18:23:42 UTC]

This is indeed an issue with -fno-delete-null-pointer-checks, the build succeeds without this flag.

[Comment 5 Joonas Niilola 2023-07-05 08:00:57 UTC]

I see the upstream bug is fixed.