85046 – alsaplayer ridiculous USE check for ogg

Bug 85046 - alsaplayer ridiculous USE check for ogg

Summary: alsaplayer ridiculous USE check for ogg

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All All

Importance:	High normal (vote)
Assignee:	Gentoo Sound Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-03-13 00:37 UTC by Jordan
Modified:	2005-03-13 06:42 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Jordan 2005-03-13 00:37:47 UTC

I'm a bit annoyed that this managed to even happen. My profile has oggvorbis in it but no ogg. This is how all the default profiles are. It's ridiculous that I should have to add a use flag for ogg just to support oggvorbis, especially considering libvorbis depends on ogg!

if ! use ogg && use oggvorbis; then
           ewarn
           ewarn "To enable oggvorbis you must enable also ogg."
           ewarn
           die "To enable oggvorbis you must enable also ogg."
fi


I understand this is trying to check whether to enable/disable ogg for things such as flac inside an ogg but this check is NOT needed for oggvorbis, as it already depends on ogg, and alsaplayer has no reason to be performing this check.

Comment 1 Jan Brinkmann (RETIRED) gentoo-dev

2005-03-13 06:42:15 UTC

removed that part, fixes in cvs. thanks