Bug 84788 – x11-themes/icewm-themes broken file permissions and backup files installed

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description James Rowe 2005-03-10 14:57:11 UTC]

icewm-themes installs loads of backup files from .xvpics and a text backup
files.  It also installs files with broken permissions including executable
data files[1] and others that are unreadable by anybody but root[2].

  The attached patch fixes both problems, by a somewhat brute force find |
xargs method.

  The patch also renders /usr/share/icewm/themes/Cyrus-IceWM/cpframes.sh
non-executable, but considering the fact it isn't even useful[3] I don't see
that it matters.  YMMV of course, in fact removing it might even make sense.
Personally I didn't see the point, as I doubt it will be the last time this
happens if more themes are added and heaps of cornercases are going to soon
get ugly ;)  (FWIW, this is the reason I chose to change permissions on
*all* files in the patch instead of just the ones which are broken now).


Reproducible: Always
Steps to Reproduce:
1.
2.
3.




1.      /usr/share/icewm/themes/icebox-red/minimizeI.xpm
        /usr/share/icewm/themes/icebox-red/closeA.xpm
        /usr/share/icewm/themes/icebox-red/closeI.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/colon.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/a.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/m.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/p.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/space.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/dot.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/n0.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/n1.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/n2.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/n3.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/n4.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/n5.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/n6.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/n7.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/n8.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/n9.xpm
        /usr/share/icewm/themes/icebox-red/ledclock/slash.xpm
        /usr/share/icewm/themes/icebox-red/default.theme
        /usr/share/icewm/themes/icebox-red/maximizeA.xpm
        /usr/share/icewm/themes/icebox-red/maximizeI.xpm
        /usr/share/icewm/themes/icebox-red/taskbar/icewm.xpm
        /usr/share/icewm/themes/icebox-red/taskbar/taskbuttonbg.xpm
        /usr/share/icewm/themes/icebox-red/taskbar/taskbarbg.xpm
        /usr/share/icewm/themes/icebox-red/taskbar/windows.xpm
        /usr/share/icewm/themes/icebox-red/taskbar/showdesktop.xpm
        /usr/share/icewm/themes/icebox-red/taskbar/taskbuttonactive.xpm
        /usr/share/icewm/themes/icebox-red/taskbar/taskbuttonminimized.xpm
        /usr/share/icewm/themes/icebox-red/taskbar/linux.xpm
        /usr/share/icewm/themes/icebox-red/restoreA.xpm
        /usr/share/icewm/themes/icebox-red/restoreI.xpm
        /usr/share/icewm/themes/icebox-red/menuButtonA.xpm
        /usr/share/icewm/themes/icebox-red/menuButtonI.xpm
        /usr/share/icewm/themes/icebox-red/minimizeA.xpm

2.      /usr/share/icewm/themes/icebox-red/taskbar/taskbarbgold.xpm
        /usr/share/icewm/themes/icebox-red/taskbar/windowsold.xpm
        /usr/share/icewm/themes/1in1-xp/default.theme

3.  It is used for generating copies of images for inactive window decs from
        active window decs.

[Comment 1 James Rowe 2005-03-10 14:57:41 UTC]

Created attachment 53099 [details, diff]
icewm-themes_b0rked-files.patch

[Comment 2 Mamoru KOMACHI (RETIRED) 2005-04-06 06:43:45 UTC]

Thanks for the bug report. Fixed in CVS.