Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 84786 - xmms-1.2.10 disk writer bug fix
Summary: xmms-1.2.10 disk writer bug fix
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All All
: High normal
Assignee: Jeremy Huddleston (RETIRED)
URL: http://www.iki.fi/shd/foss/xmms/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-10 14:45 UTC by Heikki Orsila
Modified: 2005-04-21 13:42 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Heikki Orsila 2005-03-10 14:45:19 UTC
I merged xmms-1.2.10-r13 disk writer patch with mine. The patch fixes a filename bug. Disk writing a song with filename 'mod.song_title' would generate a file name 'mod.wav'. This patch adds an option to disk write files just by appending '.wav' to the end of the filename. So 'mod.song_title.wav' would generate 'mod.song_title.wav'. By default the output plugin acts as before, but by enabling the option from gui (or editing ~/.xmms/config -> [disk_writer]) one can enable this feature.

The merged gentoo patch can be found from:
 http://www.iki.fi/shd/foss/xmms/gentoo/xmms-1.2.10-disk_writer-patch.diff

The patch alone can be found from:
 http://www.iki.fi/shd/foss/xmms/

This patch has been in Mandrake for a long time without problems. Afaik it will go to xmms-1.2.11 when released:

  http://havardk.xmms.org/dist/cvs/ChangeLog-20040426
Comment 1 Jeremy Huddleston (RETIRED) gentoo-dev 2005-04-21 02:22:49 UTC
I'm a bit confused by your changelog comment there as we are using a recent xmms snapshot as the base, and that ChangeLog snippet has nothing to do with this patch... 
Comment 2 Heikki Orsila 2005-04-21 03:53:19 UTC
My bad, somehow I pasted a wrong ChangeLog entry. How about this one then?

http://havardk.xmms.org/dist/cvs/ChangeLog-20040226
Comment 3 Jeremy Huddleston (RETIRED) gentoo-dev 2005-04-21 11:40:27 UTC
Ok, then I apologize, but I'm not quite sure what this bug report is about.  The patch mentioned in the ChangeLog is already in our patchset since we've using xmms cvs from January.
Comment 4 Heikki Orsila 2005-04-21 12:17:12 UTC
I could swear I checked that the patch doesn't exist in portage when I submitted the bug. But at least now it's there. You should close this bug :)
Comment 5 Jeremy Huddleston (RETIRED) gentoo-dev 2005-04-21 13:42:49 UTC
ok, closing.