84608 – missing variable initialization in kernel-2.eclass

Bug 84608 - missing variable initialization in kernel-2.eclass

Summary: missing variable initialization in kernel-2.eclass

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	High normal
Assignee:	Gentoo Kernel Bug Wranglers and Kernel Maintainers

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-03-09 01:52 UTC by Walter Brunner
Modified:	2005-03-09 14:04 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Walter Brunner 2005-03-09 01:52:15 UTC

In function unipatch() in kernel-2.eclass the variable z is not set to an initial value of "". Applying diffrent patches, where the order is important (UNIPATCH_STRICTORDER=1), fails.



Reproducible: Always
Steps to Reproduce:
See for example: emerge vserver-sources   (for version 1.9.4, which is based on kernel 2.6.11-rc3 and patch-2.6.11-rc3-vs1.9.4.diff in the right order)



Solution:

kernel-2.eclass:
unipatch()
                STRICT_COUNT=$((${STRICT_COUNT} + 1))
                z=""                                       # add this line
                for((y=0; y<$((6 - ${#STRICT_COUNT})); y++));
                    do z="${z}0";
                done
                STRICT_COUNT="${z}${STRICT_COUNT}"

this code section is 2 times in the unipatch()-function

Comment 1 John Mylchreest (RETIRED) gentoo-dev

2005-03-09 14:04:20 UTC

thanks for spotting that.
Fix has now been comitted into cvs.