84401 – Mistakes in CVS code: match_to_list, match_from_list, portage.py portage_util.py

Bug 84401 - Mistakes in CVS code: match_to_list, match_from_list, portage.py portage_util.py

Summary: Mistakes in CVS code: match_to_list, match_from_list, portage.py portage_util.py

Status:	RESOLVED INVALID

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Core (show other bugs)
Hardware:	All All

Importance:	High normal (vote)
Assignee:	Portage team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-03-07 07:58 UTC by Alec Warner (RETIRED)
Modified:	2005-03-13 13:52 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
fixes errors in portage.py (portage.py-CVS-03-07.patch,932 bytes, patch) 2005-03-07 08:13 UTC, Alec Warner (RETIRED)	Details \| Diff
portage_util (portage_util_CVS-03-07.patch,403 bytes, patch) 2005-03-07 08:13 UTC, Alec Warner (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Alec Warner (RETIRED) archtester

2005-03-07 07:58:03 UTC

I am reminded of carpaski's 'lists as sets' chatting in IRC :)

portage_py has a match_to_list function, however it was not qualified with a 'portage_util.' like it should have been.

match_to_list is declared and defined in portage_util.py.  However, match_to_list depends on match_from_list which is declared and defined in portage.py.  This behavior seems odd since the functions appear to do similar things.

Regardless, I've patched the required files and no longer get odd output.  However, please check over the patches to insure I didn't misinterpret the code.

Comment 1 Alec Warner (RETIRED) archtester

2005-03-07 08:13:23 UTC

Created attachment 52850 [details, diff]
fixes errors in portage.py

Comment 2 Alec Warner (RETIRED) archtester

2005-03-07 08:13:38 UTC

Created attachment 52851 [details, diff]
portage_util

Comment 3 Alec Warner (RETIRED) archtester

2005-03-13 13:52:03 UTC

I believe this is fixed,or the code moved, or something ;)