Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 84377 - gentoolkit-dev-0.2.2's echangelog renders FEATURES=autoaddcvs useless
Summary: gentoolkit-dev-0.2.2's echangelog renders FEATURES=autoaddcvs useless
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Tools (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Aron Griffis (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2005-03-07 03:14 UTC by Aaron Walker (RETIRED)
Modified: 2005-04-26 11:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Aaron Walker (RETIRED) gentoo-dev 2005-03-07 03:14:38 UTC
For example, going by my usual process:

- copy stuff over from overlay
- cvs add the ebuild and any patches, etc
$ echangelog "..."
Cvs reports the following unknown files.  Please use "cvs add" before running echangelog, or remove the files in question.
? files/digest-foo-1.0

This kind of makes FEATURES=autoaddcvs useless for digests if we have to now manually add them (as opposed to just running 'ebuild ... digest' after echangelog).  Is it possible to maybe only display the message for files other than digests?
Comment 1 Marius Mauch (RETIRED) gentoo-dev 2005-03-07 11:28:42 UTC
What has this to do with echangelog?
You should just run ebuild ... digest *before* running echangelog, that should add the digests.
Comment 2 Aaron Walker (RETIRED) gentoo-dev 2005-03-07 17:07:02 UTC
> What has this to do with echangelog?

Because it echangelog didnt complaint about it before?
Comment 3 Marius Mauch (RETIRED) gentoo-dev 2005-03-07 17:31:28 UTC
ah ok, I misunderstood the bug first.
Comment 4 Aron Griffis (RETIRED) gentoo-dev 2005-03-08 12:07:41 UTC
ka0ttic, I changed the code to ignore digests and Manifest for cvs add, the same as is done for file listing.  Please try

http://gentoo.org/~agriffis/misc/echangelog

and let me know if it works for you.  There are a few other bugfixes bundled in that, so your feedback would be appreciated.
Comment 5 Aaron Walker (RETIRED) gentoo-dev 2005-03-09 04:10:13 UTC
agriffis, that seems to fix the other bug, but not this one.  Still getting the message for digests.
Comment 6 Aron Griffis (RETIRED) gentoo-dev 2005-03-09 07:35:22 UTC
I don't believe you yet.  Please prove it with an example, and make sure that you're running the echangelog you downloaded, not the one already installed on your system.
Comment 7 Aaron Walker (RETIRED) gentoo-dev 2005-03-09 08:13:28 UTC
--(ka0ttic@zeus)-(0)--(~/cvs/gentoo-x86/app-portage/herdstat)--
>>> which echangelog
/usr/bin/echangelog
--(ka0ttic@zeus)-(0)--(~/cvs/gentoo-x86/app-portage/herdstat)--
>>> ll
total 20K
drwxr-xr-x  2 ka0ttic users  128 Mar  9 11:03 CVS
-rw-r--r--  1 ka0ttic users  658 Mar  9 11:10 ChangeLog
-rw-r--r--  1 ka0ttic users  427 Mar  9 11:10 Manifest
drwxr-xr-x  3 ka0ttic users  192 Mar  9 11:10 files
-rw-r--r--  1 ka0ttic users 1.2K Mar  9 11:10 herdstat-0.3.ebuild
-rw-r--r--  1 ka0ttic users 1.2K Mar  9 11:10 herdstat-0.4.ebuild
-rw-r--r--  1 ka0ttic users  254 Mar  9 11:10 metadata.xml
--(ka0ttic@zeus)-(0)--(~/cvs/gentoo-x86/app-portage/herdstat)--
>>> cvs add herdstat-0.4.ebuild 
cvs add: use 'cvs commit' to add this file permanently
--(ka0ttic@zeus)-(0)--(~/cvs/gentoo-x86/app-portage/herdstat)--
>>> echangelog "Version bump."
Cvs reports the following unknown files.  Please use "cvs add" before
running echangelog, or remove the files in question.
? files/digest-herdstat-0.4
--(ka0ttic@zeus)-(1)--(~/cvs/gentoo-x86/app-portage/herdstat)--
>>> mv /home/ka0ttic/echangelog /home/ka0ttic/bin/
--(ka0ttic@zeus)-(0)--(~/cvs/gentoo-x86/app-portage/herdstat)--
>>> which echangelog 
/home/ka0ttic/bin/echangelog
--(ka0ttic@zeus)-(0)--(~/cvs/gentoo-x86/app-portage/herdstat)--
>>> echangelog "Version bump."
Cvs reports the following unknown files.  Please use "cvs add" before
running echangelog, or remove the files in question.
? files/digest-herdstat-0.4
--(ka0ttic@zeus)-(1)--(~/cvs/gentoo-x86/app-portage/herdstat)--
>>> 
Comment 8 Aron Griffis (RETIRED) gentoo-dev 2005-03-09 11:42:53 UTC
I think you just showed me that you're using /usr/bin/echangelog.  Unless you downloaded from my dev-space and installed manually to /usr/bin, you're using the wrong echangelog.  Am I reading this wrong?
Comment 9 Aaron Walker (RETIRED) gentoo-dev 2005-03-09 16:10:10 UTC
Apologies maybe I should've made it easier to read.

$ which echangelog
/usr/bin/echangelog

$ ll
total 20K
drwxr-xr-x  2 ka0ttic users  128 Mar  9 11:03 CVS
-rw-r--r--  1 ka0ttic users  658 Mar  9 11:10 ChangeLog
-rw-r--r--  1 ka0ttic users  427 Mar  9 11:10 Manifest
drwxr-xr-x  3 ka0ttic users  192 Mar  9 11:10 files
-rw-r--r--  1 ka0ttic users 1.2K Mar  9 11:10 herdstat-0.3.ebuild
-rw-r--r--  1 ka0ttic users 1.2K Mar  9 11:10 herdstat-0.4.ebuild
-rw-r--r--  1 ka0ttic users  254 Mar  9 11:10 metadata.xml

$ cvs add herdstat-0.4.ebuild 
cvs add: use 'cvs commit' to add this file permanently

$ echangelog "Version bump."
Cvs reports the following unknown files.  Please use "cvs add" before
running echangelog, or remove the files in question.
? files/digest-herdstat-0.4

$ mv /home/ka0ttic/echangelog /home/ka0ttic/bin/

$ which echangelog 
/home/ka0ttic/bin/echangelog

$ echangelog "Version bump."
Cvs reports the following unknown files.  Please use "cvs add" before
running echangelog, or remove the files in question.
? files/digest-herdstat-0.4
Comment 10 Aron Griffis (RETIRED) gentoo-dev 2005-03-09 17:12:24 UTC
ka0ttic, I think you're suffering from a lack of hash.  Oh wait, that sounds wrong. ;-)  What I meant to say is that bash is hashing the location of echangelog, so in both invocations you're getting the version from /usr/bin.  The "which" command is fooling you because it is an external command that ignores bash's hash.

In other words, if you had run "rehash" prior to "echangelog" the second time, it would have worked.
Comment 11 Aaron Walker (RETIRED) gentoo-dev 2005-03-10 02:48:15 UTC
> ka0ttic, I think you're suffering from a lack of hash.
heh

yeah you're right.  didn't even think about that (should've used type instead of which).  Sorry for the waste of time.
Comment 12 Aron Griffis (RETIRED) gentoo-dev 2005-04-26 11:29:20 UTC
Fixed but forgot to mark