Bug 83996 – media-video/sswf-1.7.1 builds on amd64

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Adam Polkosnik 2005-03-03 13:34:32 UTC]

>>> media-video/sswf-1.7.1 merged.
Please add the ~amd64 keyword to ebuild

Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Actual Results:  
media-video/sswf-1.7.1

[Comment 1 Daniel Gryniewicz (RETIRED) 2005-03-03 14:15:17 UTC]

Well, it builds, and it runs, but it seems to hardloop for me.  I don't know how long these things are *suppose* to take, but I gave up after 10 minutes of it taking 99.7% of my cpu to try and build one of the samples (new-anim).  I can't mark tested under these circumstances.

[Comment 2 Danny van Dyk (RETIRED) 2005-03-03 14:30:24 UTC]

*** Bug 83998 has been marked as a duplicate of this bug. ***

[Comment 3 Danny van Dyk (RETIRED) 2005-03-03 14:36:01 UTC]

Adam: what did you do to test this package?

[Comment 4 Adam Polkosnik 2005-03-04 00:57:59 UTC]

Here are the fixed functions for 64-bit that go into 
src/lib/libsswf_tags.c++


long TagBase::SIBitSize(long value)
{
        long    cnt;

        if(value < 0) {
                // a special case
                value =~ value;
        }
        cnt = 1;
        while(value > 0) {
                cnt++;
                value=value/2;
        }
        return cnt;
}


long TagBase::UIBitSize(unsigned long value)
{
        long    cnt;

        cnt = 0;
        do {
            cnt++;
            value=value/2;
        } while(value > 0);
        return cnt;
}

[Comment 5 Adam Polkosnik 2005-03-04 00:59:34 UTC]

...and the code has been forwarded upstream. the same fix applies to both 1.7.1 and 1.7.2.

[Comment 6 Adam Polkosnik 2005-03-04 14:35:25 UTC]

Created attachment 52683 [details, diff]
patch for sswf-1.7.1 and 1.7.2

[Comment 7 Adam Polkosnik 2005-03-07 15:31:22 UTC]

Above patch fixed the "hardloop", I've wrote it, I've tested (examples worked)it on both 32 and 64 bit. I can provide ebuilds if necessary. Please let me know.

[Comment 8 Adam Polkosnik 2005-03-13 09:49:49 UTC]

Created attachment 53351 [details, diff]
this fixes a quirk in a struct

long on 64bit platform is 8 bytes, int is 4, however on 32bit it's long is 4
bytes as is int. This fixes the struct so that it is using the proper size on
64bit platform.

[Comment 9 Adam Polkosnik 2005-03-13 10:13:31 UTC]

Created attachment 53353 [details, diff]
sswf-1.7.1-r1_ebuild.patch

Patch to the 1.7.1-r1 ebuild attached. Can somebody mark it ~amd64, now that
I've fixed it up, and forwarded the changes to the author?!

[Comment 10 Daniel Gryniewicz (RETIRED) 2005-03-19 19:51:49 UTC]

Created attachment 53908 [details]
sswf-1.7.1-r1.ebuild

This works for me now.	Attached is the acutal ebuild I used for this.	I also
used the two patches from this thread, referenced in the ebuild.

[Comment 11 Simon Stelling (RETIRED) 2005-03-23 06:33:54 UTC]

Thanks for the patches, they're in CVS now!