83829 – amanda problems with large holding disks

Bug 83829 - amanda problems with large holding disks

Summary: amanda problems with large holding disks

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Current packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Robin Johnson

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2005-03-02 08:22 UTC by Andrej Filipcic
Modified:	2005-06-08 13:38 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andrej Filipcic 2005-03-02 08:22:11 UTC

amanda-2.4.4_p3 (and older) has problems with holding disks larger than 4TB.
A simple patch corrects that:

diff -ur amanda-2.4.4p3/common-src/statfs.c amanda-2.4.4p3.af/common-src/statfs.
c
--- amanda-2.4.4p3/common-src/statfs.c  2005-03-02 17:12:10.951283777 +0100
+++ amanda-2.4.4p3.af/common-src/statfs.c       2005-03-02 17:11:12.000000000 +0
100
@@ -127,7 +127,7 @@
 # endif
 #endif

-#define scale(r,s)     ( (r) == -1? -1 : (int)((r)*(double)(s)/1024.0) )
+#define scale(r,s)     ( (r) == -1? -1 : (long)((r)*(double)(s)/1024.0) )

 int get_fs_stats(dir, sp)
 char *dir;


Reproducible: Always
Steps to Reproduce:
1.
2.
3.

Comment 1 Robin Johnson archtester

2005-03-02 17:35:55 UTC

could you please submit this upstream as well?

It's good to see that some people push amanda to it's max (my holding disk is only 1TB).

Comment 2 Robin Johnson archtester

2005-06-08 13:38:18 UTC

in cvs for 2.4.5
also sent upstream now.